From: Felix Radensky <felix@embedded-sol•com>
To: Aggrwal Poonam-B10812 <Poonam.Aggrwal@freescale•com>
Cc: linuxppc-dev@ozlabs•org,
linuxppc-release@webnode01-prod1•am.freescale.net
Subject: Re: [PATCH][powerpc/85xx] P2020RDB Platform Support Added
Date: Thu, 06 Aug 2009 09:46:29 +0300 [thread overview]
Message-ID: <4A7A7C45.4040800@embedded-sol.com> (raw)
In-Reply-To: <1BD5CFC378ED0946B688E0C9BA2EF09519312F@zin33exm24.fsl.freescale.net>
Aggrwal Poonam-B10812 wrote:
>
>
>
>> -----Original Message-----
>> From: Felix Radensky [mailto:felix@embedded-sol•com]
>> Sent: Thursday, August 06, 2009 11:56 AM
>> To: Aggrwal Poonam-B10812
>> Cc: linuxppc-release@webnode01-prod1•am.freescale.net;
>> linuxppc-dev@ozlabs•org
>> Subject: Re: [PATCH][powerpc/85xx] P2020RDB Platform Support Added
>>
>> Hi, Poonam
>>
>> Poonam Aggrwal wrote:
>>
>>> Adds P2020RDB basic support in linux.
>>> Overview of P2020RDB platform
>>> - DDR
>>> DDR2 1G
>>> - NOR Flash
>>> 16MByte
>>> - NAND Flash
>>> 32MByte
>>> - 3 Ethernet interfaces
>>> 1) etSEC1
>>> - RGMII
>>> - connected to a 5 port Vitesse Switch(VSC7385)
>>> - Switch is memory mapped through eLBC interface(CS#2)
>>> - IRQ1
>>> 2) etSEC2
>>> - SGMII
>>> - connected to VSC8221
>>> - IRQ2
>>> 3) etSEC3
>>> - RGMII
>>> - connected to VSC8641
>>> - IRQ3
>>> - 2 1X PCIe interfaces
>>> - SD/MMC ,USB
>>> - SPI EEPROM
>>> - Serial I2C EEPROM
>>>
>>> Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale•com>
>>> ---
>>> based on
>>>
>> http://www.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git
>>
>>> arch/powerpc/boot/dts/p2020rdb.dts | 586
>>>
>> +++++++++++++++++++++++++++++
>>
>>> arch/powerpc/configs/mpc85xx_defconfig | 1 +
>>> arch/powerpc/platforms/85xx/Kconfig | 9 +
>>> arch/powerpc/platforms/85xx/Makefile | 3 +-
>>> arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 141 +++++++
>>> 5 files changed, 739 insertions(+), 1 deletions(-) create mode
>>> 100644 arch/powerpc/boot/dts/p2020rdb.dts
>>> create mode 100644 arch/powerpc/platforms/85xx/mpc85xx_rdb.c
>>>
>>> diff --git a/arch/powerpc/boot/dts/p2020rdb.dts
>>> b/arch/powerpc/boot/dts/p2020rdb.dts
>>> new file mode 100644
>>> index 0000000..d6d8131
>>> --- /dev/null
>>> +++ b/arch/powerpc/boot/dts/p2020rdb.dts
>>> @@ -0,0 +1,586 @@
>>> +/*
>>> + * P2020 RDB Device Tree Source
>>> + *
>>> + * Copyright 2009 Freescale Semiconductor Inc.
>>> + *
>>> + * This program is free software; you can redistribute it and/or
>>> +modify it
>>> + * under the terms of the GNU General Public License as
>>>
>> published
>>
>>> +by the
>>> + * Free Software Foundation; either version 2 of the License, or
>>> +(at your
>>> + * option) any later version.
>>> + */
>>> +
>>> +/dts-v1/;
>>> +/ {
>>> + model = "fsl,P2020";
>>> + compatible = "fsl,P2020RDB";
>>> + #address-cells = <2>;
>>> + #size-cells = <2>;
>>> +
>>> + aliases {
>>> + ethernet0 = &enet0;
>>> + ethernet1 = &enet1;
>>> + ethernet2 = &enet2;
>>> + serial0 = &serial0;
>>> + serial1 = &serial1;
>>> + pci0 = &pci0;
>>> + pci1 = &pci1;
>>> + };
>>> +
>>> + cpus {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + PowerPC,P2020@0 {
>>> + device_type = "cpu";
>>> + reg = <0x0>;
>>> + next-level-cache = <&L2>;
>>> + };
>>> +
>>> + PowerPC,P2020@1 {
>>> + device_type = "cpu";
>>> + reg = <0x1>;
>>> + next-level-cache = <&L2>;
>>> + };
>>> + };
>>> +
>>> + memory {
>>> + device_type = "memory";
>>> + };
>>> +
>>> + localbus@ffe05000 {
>>> + #address-cells = <2>;
>>> + #size-cells = <1>;
>>> + compatible = "fsl,p2020-elbc", "fsl,elbc", "simple-bus";
>>> + reg = <0 0xffe05000 0 0x1000>;
>>> + interrupts = <19 2>;
>>> + interrupt-parent = <&mpic>;
>>> +
>>> + /* NOR and NAND Flashes */
>>> + ranges = <0x0 0x0 0x0 0xef000000 0x01000000
>>> + 0x1 0x0 0x0 0xffa00000 0x00040000
>>> + 0x2 0x0 0x0 0xffb00000 0x08000000>;
>>>
>>>
>> The comment is a bit misleading, CS2 is L2 switch.
>>
> Okay will modify it.
>
>> Also, are
>> you sure the CS2 range shouldn't look like
>>
>> 0x2 0x0 0x0 0xffb00000 0x00020000
>>
>> That's what L2switch reg property suggests.
>>
> Thanks , for catching it!...this is a bug , I changed the size in the
> reg property but not in the ranges.
>
>>> +
>>> + nor@0,0 {
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + compatible = "cfi-flash";
>>> + reg = <0x0 0x0 0x1000000>;
>>> + bank-width = <2>;
>>> + device-width = <1>;
>>> +
>>> + vitesse-7385-fw@0 {
>>> + /* This location must not be altered */
>>> + /* 256KB for Vitesse 7385
>>>
>> Switch firmware */
>>
>>> + reg = <0x0 0x00040000>;
>>> + label = "NOR (RO) Vitesse-7385
>>>
>> Firmware";
>>
>>> + read-only;
>>> + };
>>>
>>>
>> Partitions should be declared as
>>
>> partition@0 {
>> reg = ...
>> label = ...
>> ...
>> }
>>
> Doing it this way is good from readability perspective, but we generally
> do not use this convention in our platforms eg 8572DS, etc
>
>
>
I think the DTS for 8572 should be fixed as well. The OF partition
parser does
not recognize your syntax and partitions will not appear in /proc/mtd.
I've encountered
this recently with mainline port of 8536DS. I've tried to copy partition
info from 8572
and it didn't work until I've switched to new syntax.
Felix.
next prev parent reply other threads:[~2009-08-06 6:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 4:23 [PATCH][powerpc/85xx] P2020RDB Platform Support Added Poonam Aggrwal
2009-08-06 6:25 ` Felix Radensky
2009-08-06 6:37 ` Aggrwal Poonam-B10812
2009-08-06 6:46 ` Felix Radensky [this message]
2009-08-06 7:14 ` Aggrwal Poonam-B10812
2009-08-06 11:34 ` Aggrwal Poonam-B10812
2009-08-06 23:30 ` Sean MacLennan
2009-09-24 18:11 ` Kumar Gala
2009-09-25 4:18 ` Aggrwal Poonam-B10812
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A7A7C45.4040800@embedded-sol.com \
--to=felix@embedded-sol$(echo .)com \
--cc=Poonam.Aggrwal@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=linuxppc-release@webnode01-prod1$(echo .)am.freescale.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox