Subject: Re: [PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52

From: Heiko Schocher <[email-masked]>
Date: Mon, 14 Sep 2009 16:09:32 +0200

Hello Wolfram,

Wolfram Sang wrote:
> Hi,
> 
>> +		mpc5200_pic: interrupt-controller@500 {
>> +			// 5200 interrupts are encoded into two levels;
> 
> Grant, maybe this comment could be dropped also for the in-kernel dts-files? I
> think it is sufficently described in mpc5200.txt. I could prepare a patch if
> you agree.
> 
>> +		i2c@3d40 {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +			compatible = "fsl,mpc5200-i2c","fsl-i2c";
>> +			reg = <0x3d40 0x40>;
>> +			interrupts = <2 16 0>;
>> +			fsl5200-clocking;
> 
> Please drop the clocking-line. It became obsolete.

OK, I fix this.

Thanks for reviewing

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany