From: Wolfgang Grandegger <wg@grandegger•com>
To: Joakim Tjernlund <Joakim.Tjernlund@transmode•se>
Cc: linuxppc-dev@ozlabs•org, linux-i2c@vger•kernel.org,
Esben Haabendal <eha@doredevelopment•dk>
Subject: Re: [PATCH] i2c-mpc: Do not generate STOP after read.
Date: Fri, 25 Sep 2009 12:01:17 +0200 [thread overview]
Message-ID: <4ABC94ED.6070508@grandegger.com> (raw)
In-Reply-To: <1253620242-18461-1-git-send-email-Joakim.Tjernlund@transmode.se>
Joakim Tjernlund wrote:
> The driver always ends a read with a STOP condition which
> breaks subsequent I2C reads/writes in the same transaction as
> these expect to do a repeated START(ReSTART).
>
> This will also help I2C multimaster as the bus will not be released
> after the first read, but when the whole transaction ends.
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode•se>
Tested-by: Wolfgang Grandegger <wg@grandegger•com>
on a MPC8548 board with an up-to-date kernel. I did not realize any
problems.
Wolfgang.
next prev parent reply other threads:[~2009-09-25 10:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 11:50 [PATCH] i2c-mpc: Do not generate STOP after read Joakim Tjernlund
2009-09-25 10:01 ` Wolfgang Grandegger [this message]
2009-09-27 22:26 ` Joakim Tjernlund
2009-09-28 7:28 ` Jean Delvare
2009-09-28 7:30 ` Joakim Tjernlund
2009-09-28 7:33 ` Peter Korsgaard
2009-09-28 7:34 ` Jean Delvare
2009-09-28 7:43 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABC94ED.6070508@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=Joakim.Tjernlund@transmode$(echo .)se \
--cc=eha@doredevelopment$(echo .)dk \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox