Subject: Re: [PATCH v2] mpc5200: support for the MAN mpc5200 based board uc101

From: Heiko Schocher <[email-masked]>
Date: Mon, 05 Oct 2009 12:12:58 +0200

Hello Wolfram,

Wolfram Sang wrote:
> On Mon, Oct 05, 2009 at 09:46:43AM +0200, Heiko Schocher wrote:
> 
>> - serial Console on PSC1
>> - 64MB SDRAM
>> - MTD CFI Flash
>> - Ethernet FEC
>> - IDE support
>>
>> Signed-off-by: Heiko Schocher <[email-masked]>
[...]
> [...]
>> +		wdt {
>> +			compatible = "generic,gpio-wdt";
>> +			reg = <0x600 0x10>;
>> +			gpios = <&gpt0 0 0>;
>> +			period = <500>;	// WDT trigger period in msec
>> +		};
> 
> Is this an official binding? I also did an gpio-watchdog a while ago and there
> were some issues with the binding, IIRC. Would be nice if this has been solved
> meanwhile.

Oh, sorry, no. I remove it.

> Other than that, it looks okay to me.

Ok, thanks for reviewing, I resent soon an update

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany