From: Albert Herranz <albert_herranz@yahoo•es>
To: Segher Boessenkool <segher@kernel•crashing.org>
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: [RFC PATCH 05/19] powerpc: wii: bootwrapper bits
Date: Tue, 24 Nov 2009 18:56:49 +0100 [thread overview]
Message-ID: <4B0C1E61.6010101@yahoo.es> (raw)
In-Reply-To: <90646C9F-F27D-47AD-9985-83DB7381D6BF@kernel.crashing.org>
Segher Boessenkool wrote:
>> + * We enter with an unknown cache, high BATs and MMU status.
>
> What does this mean? You know the low four BATs on entry and
> nothing else?
>
That means that we do not make assumptions regarding:
- the state of the cache (enabled vs disabled)
- if the high BATs are enabled or not
- if the MMU is enabled or not
Is this clearer? I'm not a native english speaker as you may have noticed already :-P
>> +asm ("\n\
>
> Global asm() is evil.
>
Yes, you said. Still, I'd like a proper argument :)
>> + mfmsr 9\n\
>> + andi. 0, 9, (1<<4)|(1<<5) /* MSR_DR|MSR_IR */\n\
>
>> + andc 9, 9, 0\n\
>
> mfmsr 9 ; rlwinm 9,9,0,~0x30 ?
>
Yes. Maybe
mfmsr 9 ; rlwinm 9,9,0,~((1<<4)|(1<<5)) /* MSR_DR|MSR_IR */
>> + mtspr 0x01a, 8 /* SRR0 */\n\
>> + mtspr 0x01b, 9 /* SRR1 */\n\
>
> mtsrr0 and mtsrr1
>
Easier :)
>> + sync\n\
>> + rfi\n\
>
> No need for sync before rfi
>
Ok.
>> + mtspr 0x210, 8 /* IBAT0U */\n\
>> + mtspr 0x211, 8 /* IBAT0L */\n\
>
> You only need to set the upper BAT to zero, saves some code.
>
Great. Is this documented somewhere?
>> + isync\n\
>
> isync here is cargo cult
>
I'll offer a dead chicken to compensate for this.
>> + li 8, 0x01ff /* first 16MiB */\n\
>> + li 9, 0x0002 /* rw */\n\
>> + mtspr 0x210, 8 /* IBAT0U */\n\
>> + mtspr 0x211, 9 /* IBAT0L */\n\
>> + mtspr 0x218, 8 /* DBAT0U */\n\
>> + mtspr 0x219, 9 /* DBAT0L */\n\
>
> M=0 for RAM?
>
See analog question for gamecube bootwrapper bits.
>>
>
> Also, you should normally write the lower BAT first. Doesn't matter
> here because IR=DR=0 of course.
>
I can change that too if it's the general way to go.
>> + lis 8, 0xcc00 /* I/O mem */\n\
>> + ori 8, 8, 0x3ff /* 32MiB */\n\
>> + lis 9, 0x0c00\n\
>> + ori 9, 9, 0x002a /* uncached, guarded, rw */\n\
>> + mtspr 0x21a, 8 /* DBAT1U */\n\
>> + mtspr 0x21b, 9 /* DBAT1L */\n\
>
> Is there any real reason you don't identity map this?
>
No. There's a bit of nostalgia there.
(On the other hand there's no real reason to identity map it).
>> + sync\n\
>> + isync\n\
>> +\n\
>
> Don't need these
>
I'll get rid of them, then.
>> + /* enable high BATs */\n\
>> + lis 8, 0x8200\n\
>> + mtspr 0x3f3, 8 /* HID4 */\n\
>
> You need to use read-modify-write here. Also, shouldn't you
> enable the extra BATs before setting them?
>
No. You should first set them up and then enable them.
The content of the HIGH BATs is undefined on boot, AFAIK.
> And you _do_ need isync here as far as I can see.
>
>> + /* enable caches */\n\
>> + mfspr 8, 0x3f0\n\
>> + ori 8, 8, 0xc000\n\
>> + mtspr 0x3f0, 8 /* HID0 */\n\
>> + isync\n\
>
> You need to invalidate the L1 caches at the same time as you enable
> them.
>
Ok. I'll check if the caches are enabled. If they aren't I'll invalidate and enable them.
>> +void platform_init(unsigned long r3, unsigned long r4, unsigned long r5)
>> +{
>> + u32 heapsize = 24*1024*1024 - (u32)_end;
>> +
>> + simple_alloc_init(_end, heapsize, 32, 64);
>> + fdt_init(_dtb_start);
>> +
>> + if (!ug_grab_io_base() && ug_is_adapter_present())
>
> The "!" reads weird. Can you not make ug_is_adapter_present()
> call ug_grab_io_base(), anyway?
>
Calling ug_grab_io_base() from ug_is_adapter_present() can be misleading too (you are supposed to just check if the adapter is present in that function, according to the name).
If the "!" is ugly I can use the following idiom, introducing an error variable.
error = ug_grab_io_base();
if (!error && ug_is_adapter_present())
/* blah */
Thanks,
Albert
next prev parent reply other threads:[~2009-11-24 17:56 UTC|newest]
Thread overview: 181+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-22 22:01 [RFC PATCH 00/19] powerpc: nintendo gamecube and wii support Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 01/19] powerpc: gamecube/wii: usbgecko bootwrapper console support Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 02/19] powerpc: gamecube: device tree Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 03/19] powerpc: gamecube: bootwrapper bits Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 04/19] powerpc: wii: device tree Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 05/19] powerpc: wii: bootwrapper bits Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 06/19] powerpc: gamecube/wii: introduce GAMECUBE_COMMON Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 07/19] powerpc: gamecube/wii: declare as non-coherent platforms Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 08/19] powerpc: gamecube/wii: do not include PCI support Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 09/19] powerpc: gamecube/wii: udbg support for usbgecko Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 10/19] powerpc: gamecube/wii: early debugging using usbgecko Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 11/19] powerpc: gamecube/wii: flipper interrupt controller support Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 12/19] powerpc: gamecube: platform support Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 13/19] powerpc: gamecube: default config Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 14/19] powerpc: allow ioremap within reserved fake ram regions Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 15/19] powerpc: broadway processor support Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 16/19] powerpc: wii: hollywood interrupt controller support Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 17/19] powerpc: wii: bootmii starlet 'mini' firmware support Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 18/19] powerpc: wii: platform support Albert Herranz
2009-11-22 22:01 ` [RFC PATCH 19/19] powerpc: wii: default config Albert Herranz
2009-11-22 23:45 ` [RFC PATCH 18/19] powerpc: wii: platform support Grant Likely
2009-11-23 20:21 ` Albert Herranz
2009-11-24 22:24 ` Segher Boessenkool
2009-11-25 17:58 ` Albert Herranz
2009-11-26 22:05 ` Segher Boessenkool
2009-11-22 22:48 ` [RFC PATCH 17/19] powerpc: wii: bootmii starlet 'mini' firmware support Arnd Bergmann
2009-11-23 19:21 ` Albert Herranz
2009-11-24 22:13 ` Segher Boessenkool
2009-11-25 17:47 ` Albert Herranz
2009-11-26 22:00 ` Segher Boessenkool
2009-11-22 23:40 ` [RFC PATCH 16/19] powerpc: wii: hollywood interrupt controller support Grant Likely
2009-11-23 20:18 ` Albert Herranz
2009-11-24 21:54 ` Segher Boessenkool
2009-11-25 17:27 ` Albert Herranz
2009-11-26 5:23 ` Benjamin Herrenschmidt
2009-11-26 15:42 ` Albert Herranz
2009-11-26 21:13 ` Benjamin Herrenschmidt
2009-11-26 23:03 ` Segher Boessenkool
2009-11-22 23:38 ` [RFC PATCH 15/19] powerpc: broadway processor support Grant Likely
2009-11-23 20:16 ` Albert Herranz
2009-11-22 23:36 ` [RFC PATCH 14/19] powerpc: allow ioremap within reserved fake ram regions Grant Likely
2009-11-23 20:16 ` Albert Herranz
2009-11-23 20:41 ` Grant Likely
2009-11-23 23:45 ` Michael Ellerman
2009-11-24 17:09 ` Albert Herranz
2009-11-25 0:38 ` Michael Ellerman
2009-11-26 5:22 ` Benjamin Herrenschmidt
2009-11-26 15:35 ` Albert Herranz
2009-11-26 21:13 ` Benjamin Herrenschmidt
2009-11-22 23:34 ` [RFC PATCH 12/19] powerpc: gamecube: platform support Grant Likely
2009-11-23 20:02 ` Albert Herranz
2009-11-24 21:39 ` Segher Boessenkool
2009-11-25 17:24 ` Albert Herranz
2009-11-26 21:53 ` Segher Boessenkool
2009-11-26 22:07 ` Albert Herranz
2009-11-27 0:09 ` Segher Boessenkool
2009-11-27 21:35 ` Benjamin Herrenschmidt
2009-11-28 3:56 ` Grant Likely
2009-11-28 3:56 ` Grant Likely
2009-11-22 23:28 ` [RFC PATCH 11/19] powerpc: gamecube/wii: flipper interrupt controller support Grant Likely
2009-11-23 19:59 ` Albert Herranz
2009-11-26 5:18 ` Benjamin Herrenschmidt
2009-11-26 15:33 ` Albert Herranz
2009-11-26 21:12 ` Benjamin Herrenschmidt
2009-11-26 23:00 ` Segher Boessenkool
2009-11-26 23:38 ` Benjamin Herrenschmidt
2009-11-24 21:30 ` Segher Boessenkool
2009-11-25 17:13 ` Albert Herranz
2009-11-26 21:52 ` Segher Boessenkool
2009-11-26 22:05 ` Albert Herranz
2009-11-27 0:06 ` Segher Boessenkool
2009-11-27 12:17 ` Segher Boessenkool
2009-11-27 17:27 ` Albert Herranz
2009-11-27 21:34 ` Benjamin Herrenschmidt
2009-11-28 2:04 ` Segher Boessenkool
2009-11-28 2:26 ` Benjamin Herrenschmidt
2009-11-26 5:18 ` Benjamin Herrenschmidt
2009-11-26 15:30 ` Albert Herranz
2009-11-26 21:10 ` Benjamin Herrenschmidt
2009-11-22 22:27 ` [RFC PATCH 10/19] powerpc: gamecube/wii: early debugging using usbgecko Arnd Bergmann
2009-11-23 19:10 ` Albert Herranz
2009-11-23 22:13 ` Arnd Bergmann
2009-11-26 5:14 ` Benjamin Herrenschmidt
2009-11-26 22:54 ` Segher Boessenkool
2009-11-26 23:27 ` Benjamin Herrenschmidt
2009-11-24 0:54 ` Segher Boessenkool
2009-11-24 18:19 ` Albert Herranz
2009-11-22 23:22 ` [RFC PATCH 09/19] powerpc: gamecube/wii: udbg support for usbgecko Grant Likely
2009-11-24 0:49 ` Segher Boessenkool
2009-11-24 18:08 ` Albert Herranz
2009-11-24 21:19 ` Segher Boessenkool
2009-11-25 17:07 ` Albert Herranz
2009-11-26 5:12 ` Benjamin Herrenschmidt
2009-11-26 15:28 ` Albert Herranz
2009-11-26 21:02 ` Benjamin Herrenschmidt
2009-11-26 23:12 ` Segher Boessenkool
2009-11-22 23:21 ` [RFC PATCH 08/19] powerpc: gamecube/wii: do not include PCI support Grant Likely
2009-11-26 5:10 ` Benjamin Herrenschmidt
2009-11-22 22:20 ` [RFC PATCH 07/19] powerpc: gamecube/wii: declare as non-coherent platforms Arnd Bergmann
2009-11-23 19:06 ` Albert Herranz
2009-11-26 5:09 ` Benjamin Herrenschmidt
2009-11-22 23:20 ` [RFC PATCH 06/19] powerpc: gamecube/wii: introduce GAMECUBE_COMMON Grant Likely
2009-11-23 19:56 ` Albert Herranz
2009-11-24 0:35 ` Segher Boessenkool
2009-11-24 18:03 ` Albert Herranz
2009-11-24 21:15 ` Segher Boessenkool
2009-11-24 22:33 ` Arnd Bergmann
2009-11-25 17:06 ` Albert Herranz
2009-11-26 5:08 ` Benjamin Herrenschmidt
2009-11-26 15:22 ` Albert Herranz
2009-11-27 12:12 ` Segher Boessenkool
2009-11-22 23:19 ` [RFC PATCH 05/19] powerpc: wii: bootwrapper bits Grant Likely
2009-11-24 0:33 ` Segher Boessenkool
2009-11-24 17:56 ` Albert Herranz [this message]
2009-11-24 21:13 ` Segher Boessenkool
2009-11-22 23:18 ` [RFC PATCH 04/19] powerpc: wii: device tree Grant Likely
2009-11-23 19:54 ` Albert Herranz
2009-11-23 20:36 ` Grant Likely
2009-11-23 21:55 ` Albert Herranz
2009-11-25 16:57 ` Segher Boessenkool
2009-11-25 18:09 ` Albert Herranz
2009-11-25 17:49 ` Segher Boessenkool
2009-11-25 18:34 ` Albert Herranz
2009-11-26 4:58 ` Benjamin Herrenschmidt
2009-11-26 15:19 ` Albert Herranz
2009-11-26 4:51 ` Benjamin Herrenschmidt
2009-11-26 15:18 ` Albert Herranz
2009-11-26 21:01 ` Benjamin Herrenschmidt
2009-11-26 21:38 ` Albert Herranz
2009-11-26 22:37 ` Benjamin Herrenschmidt
2009-11-27 0:16 ` Segher Boessenkool
2009-11-27 0:15 ` Benjamin Herrenschmidt
2009-11-26 23:25 ` Segher Boessenkool
2009-11-26 22:50 ` Segher Boessenkool
2009-11-26 23:02 ` Albert Herranz
2009-11-26 4:45 ` Benjamin Herrenschmidt
2009-11-26 15:09 ` Albert Herranz
2009-11-26 20:48 ` Benjamin Herrenschmidt
2009-11-26 21:20 ` Albert Herranz
2009-11-26 23:17 ` Segher Boessenkool
2009-11-26 22:45 ` Segher Boessenkool
2009-11-22 23:11 ` [RFC PATCH 03/19] powerpc: gamecube: bootwrapper bits Grant Likely
2009-11-24 0:08 ` Segher Boessenkool
2009-11-24 17:38 ` Albert Herranz
2009-11-24 21:00 ` Segher Boessenkool
2009-11-24 23:45 ` Albert Herranz
2009-11-25 16:53 ` Segher Boessenkool
2009-11-26 4:36 ` Benjamin Herrenschmidt
2009-11-26 8:17 ` Gabriel Paubert
2009-11-26 8:46 ` Benjamin Herrenschmidt
2009-11-26 23:06 ` Segher Boessenkool
2009-11-26 4:35 ` Benjamin Herrenschmidt
2009-11-26 22:23 ` Segher Boessenkool
2009-11-22 23:02 ` [RFC PATCH 02/19] powerpc: gamecube: device tree Grant Likely
2009-11-23 19:44 ` Albert Herranz
2009-11-23 20:19 ` Grant Likely
2009-11-23 20:25 ` Albert Herranz
2009-11-24 22:53 ` Segher Boessenkool
2009-11-26 4:23 ` Benjamin Herrenschmidt
2009-11-27 12:09 ` Segher Boessenkool
2009-11-24 22:36 ` Segher Boessenkool
2009-11-26 4:23 ` Benjamin Herrenschmidt
2009-11-26 22:15 ` Segher Boessenkool
2009-11-26 22:38 ` Benjamin Herrenschmidt
2009-11-27 0:18 ` Segher Boessenkool
2009-11-26 4:21 ` Benjamin Herrenschmidt
2009-11-26 4:38 ` Grant Likely
2009-11-26 5:29 ` Benjamin Herrenschmidt
2009-11-26 5:51 ` Grant Likely
2009-11-26 22:30 ` Segher Boessenkool
2009-11-25 18:00 ` Segher Boessenkool
2009-11-25 18:43 ` Albert Herranz
2009-11-27 12:07 ` Segher Boessenkool
2009-11-26 4:27 ` Benjamin Herrenschmidt
2009-11-26 22:19 ` Segher Boessenkool
2009-11-22 22:50 ` [RFC PATCH 01/19] powerpc: gamecube/wii: usbgecko bootwrapper console support Grant Likely
2009-11-26 4:12 ` Benjamin Herrenschmidt
2009-11-22 22:48 ` [RFC PATCH 00/19] powerpc: nintendo gamecube and wii support Grant Likely
2009-11-22 22:49 ` Arnd Bergmann
2009-11-23 19:22 ` Albert Herranz
2009-11-23 5:13 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0C1E61.6010101@yahoo.es \
--to=albert_herranz@yahoo$(echo .)es \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=segher@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox