Subject: Re: [PATCH] PPC: Sync guest visible MMU state

From: Avi Kivity <[email-masked]>
Date: Thu, 26 Nov 2009 15:20:09 +0200

On 11/26/2009 03:16 PM, Alexander Graf wrote:
>
>> You can keep pvr out of the (named) union.
>>      
>
> So we'd have
>
> sregs.padded.ppc64.slb?
>
>    

or sregs.u.ppc64.slb.

> I don't see how that is an improvement.
>    

Buildability takes precedence.

(an alternative is to drop the union, and add a BUILD_BUG_ON(sizeof...)).

-- 
error compiling committee.c: too many arguments to function