public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Felix Radensky <felix@embedded-sol•com>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: Stef van Os <stef.van.os@Prodrive•nl>, Stefan Roese <sr@denx•de>,
	Feng Kan <fkan@amcc•com>,
	linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powerpc/4xx: Add support for type 1 pci transactions on 4xx boards
Date: Wed, 20 Jan 2010 13:21:31 +0200	[thread overview]
Message-ID: <4B56E73B.8040903@embedded-sol.com> (raw)
In-Reply-To: <1263941873.724.524.camel@pasglop>

Hi, Stef

Benjamin Herrenschmidt wrote:
> On Wed, 2010-01-20 at 00:52 +0200, Felix Radensky wrote:
>   
>> 405XX - no
>> 440EP - no
>> 440GR - no
>> 440EPx/440GRx - no
>>
>> 440GP - yes
>> 440GX - yes
>> 440SP - yes
>> 440SPe - yes
>> 460XX - yes
>>
>> The distinction between these groups is pretty clear in the device trees.
>> The members of the first group all have "ibm,plb-pci" property, and all
>> members of second group have "ibm,plb-pcix" property.
>>
>> So only ppc4xx_probe_pcix_bridge() routine should be fixed.
>>     
>
> Ah cool, I hadn't noticed that it matched the cell type.
>
>   

Can you please send an updated patch.

Thanks a lot.

Felix.

      reply	other threads:[~2010-01-20 11:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-12 14:09 [PATCH] powerpc/4xx: Add support for type 1 pci transactions on 4xx boards Stef van Os
2010-01-12 23:18 ` Benjamin Herrenschmidt
2010-01-14  4:56   ` Benjamin Herrenschmidt
2010-01-19 22:52     ` Felix Radensky
2010-01-19 22:57       ` Benjamin Herrenschmidt
2010-01-20 11:21         ` Felix Radensky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B56E73B.8040903@embedded-sol.com \
    --to=felix@embedded-sol$(echo .)com \
    --cc=benh@kernel$(echo .)crashing.org \
    --cc=fkan@amcc$(echo .)com \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=sr@denx$(echo .)de \
    --cc=stef.van.os@Prodrive$(echo .)nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox