Subject: Re: [PATCHv2 2/2] Update ibm,client-architecture call field based on device tree

From: Joel Schopp <[email-masked]>
Date: Tue, 02 Feb 2010 12:37:19 -0600

>> +		if(*cores != NR_CPUS)
>> +			prom_printf("client-architecture structure corrupted\n");
>> +		*cores = (NR_CPUS / prom_smt_way());
>> +		prom_printf("setting client-architecture cores to %x\n", *cores);
>>     
>
> I don't know if I'm painting a bike shed of if this is a real concern, but if
> *cores isn't NR_CPUS shouldn't we do nothing rather then clobbering it?
>
> Yours Tony
>   
If it isn't NR_CPUS we're pretty broken if we set it or if we don't.  My 
previous version did a BUILD_BUG_ON() but Ben didn't like that and said 
he preferred just a warning message.