From: Wolfgang Grandegger <wg@grandegger•com>
To: Grant Likely <grant.likely@secretlab•ca>
Cc: Ben Dooks <ben-linux@fluff•org>,
Devicetree-discuss@lists•ozlabs.org,
Linuxppc-dev@lists•ozlabs.org, Linux-i2c@vger•kernel.org,
Wolfgang Grandegger <wg@denx•de>
Subject: Re: [PATCH v7 1/4] i2c-mpc: use __devinit[data] for initialization functions and data
Date: Tue, 16 Feb 2010 21:49:46 +0100 [thread overview]
Message-ID: <4B7B04EA.9010707@grandegger.com> (raw)
In-Reply-To: <fa686aa41002161040kada217ds1f63d363157e08ab@mail.gmail.com>
Grant Likely wrote:
> On Wed, Feb 10, 2010 at 7:55 AM, Wolfgang Grandegger <wg@grandegger•com> wrote:
>> From: Wolfgang Grandegger <wg@denx•de>
>>
>> "__devinit[data]" has not yet been used for all initialization functions
>> and data. To avoid truncating lines, the struct "mpc_i2c_match_data" has
>> been renamed to "mpc_i2c_data", which is even the better name.
>>
>> Signed-off-by: Wolfgang Grandegger <wg@denx•de>
>> Tested-by: Wolfram Sang <w.sang@pengutronix•de>
>
> Between patch 1 & 2 is not bisectable. Functions still called
> *_setclock in this patch, but referenced as *_setup in the structure.
> Please respin.
Argh, sorry for the mess. I will fix it tomorrow.
> Also ...
>
>> +static struct mpc_i2c_data mpc_i2c_data_52xx __devinitdata = {
>> + .setup = mpc_i2c_setup_52xx,
>> +};
>> +
>> +static struct mpc_i2c_data mpc_i2c_data_8313 __devinitdata = {
>> + .setup = mpc_i2c_setup_8xxx,
>> +};
>> +
>> +static struct mpc_i2c_data mpc_i2c_data_8543 __devinitdata = {
>> + .setup = mpc_i2c_setup_8xxx,
>> + .prescaler = 2,
>> +};
>> +
>> +static struct mpc_i2c_data mpc_i2c_data_8544 __devinitdata = {
>> + .setup = mpc_i2c_setup_8xxx,
>> + .prescaler = 3,
>> +};
>> +
>> static const struct of_device_id mpc_i2c_of_match[] = {
>> - {.compatible = "mpc5200-i2c",
>> - .data = &(struct mpc_i2c_match_data) {
>> - .setclock = mpc_i2c_setclock_52xx,
>> - },
>> - },
>> - {.compatible = "fsl,mpc5200b-i2c",
>> - .data = &(struct mpc_i2c_match_data) {
>> - .setclock = mpc_i2c_setclock_52xx,
>> - },
>> - },
>> - {.compatible = "fsl,mpc5200-i2c",
>> - .data = &(struct mpc_i2c_match_data) {
>> - .setclock = mpc_i2c_setclock_52xx,
>> - },
>> - },
>> - {.compatible = "fsl,mpc8313-i2c",
>> - .data = &(struct mpc_i2c_match_data) {
>> - .setclock = mpc_i2c_setclock_8xxx,
>> - },
>> - },
>> - {.compatible = "fsl,mpc8543-i2c",
>> - .data = &(struct mpc_i2c_match_data) {
>> - .setclock = mpc_i2c_setclock_8xxx,
>> - .prescaler = 2,
>> - },
>> - },
>> - {.compatible = "fsl,mpc8544-i2c",
>> - .data = &(struct mpc_i2c_match_data) {
>> - .setclock = mpc_i2c_setclock_8xxx,
>> - .prescaler = 3,
>> - },
>> + {.compatible = "mpc5200-i2c", .data = &mpc_i2c_data_52xx, },
>> + {.compatible = "fsl,mpc5200b-i2c", .data = &mpc_i2c_data_52xx, },
>> + {.compatible = "fsl,mpc5200-i2c", .data = &mpc_i2c_data_52xx, },
>> + {.compatible = "fsl,mpc8313-i2c", .data = &mpc_i2c_data_8313, },
>> + {.compatible = "fsl,mpc8543-i2c", .data = &mpc_i2c_data_8543, },
>> + {.compatible = "fsl,mpc8544-i2c", .data = &mpc_i2c_data_8544, },
>
> ... what was wrong with the old format of declaring the .data
> structures inline with the match table?
It does not allow to use __devinitdata because the space reserved by the
compiler does belong to another section. In other words it was necessary
to get ride of section mismatches.
Wolfgang.
next prev parent reply other threads:[~2010-02-16 20:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 14:55 [PATCH v7 0/4] i2c-mpc: add support for the Freescale MPC512x and other fixes Wolfgang Grandegger
2010-02-10 14:55 ` [PATCH v7 1/4] i2c-mpc: use __devinit[data] for initialization functions and data Wolfgang Grandegger
2010-02-10 14:55 ` [PATCH v7 2/4] i2c-mpc: rename "setclock" initialization functions to "setup" Wolfgang Grandegger
2010-02-10 14:55 ` [PATCH v7 3/4] i2c-mpc: add support for the MPC512x processors from Freescale Wolfgang Grandegger
2010-02-10 14:55 ` [PATCH v7 4/4] powerpc: doc/dts-bindings: update doc of FSL I2C bindings Wolfgang Grandegger
2010-02-16 18:40 ` [PATCH v7 1/4] i2c-mpc: use __devinit[data] for initialization functions and data Grant Likely
2010-02-16 20:49 ` Wolfgang Grandegger [this message]
2010-02-15 19:34 ` [PATCH v7 0/4] i2c-mpc: add support for the Freescale MPC512x and other fixes Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7B04EA.9010707@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=Devicetree-discuss@lists$(echo .)ozlabs.org \
--cc=Linux-i2c@vger$(echo .)kernel.org \
--cc=Linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=ben-linux@fluff$(echo .)org \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=wg@denx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox