From: "Kári Davíðsson" <kari.davidsson@marel•com>
To: "dedekind1@gmail•com" <dedekind1@gmail•com>
Cc: Piotr Ziecik <kosmo@semihalf•com>, Detlev Zundel <dzu@denx•de>,
"linuxppc-dev@ozlabs•org" <linuxppc-dev@ozlabs•org>,
"linux-mtd@lists•infradead.org" <linux-mtd@lists•infradead.org>,
Anatolij Gustschin <agust@denx•de>,
David Woodhouse <dwmw2@infradead•org>
Subject: Re: [PATCH v4 04/11] mtd: Add MPC5121 NAND Flash Controller driver
Date: Tue, 23 Feb 2010 15:54:04 +0000 [thread overview]
Message-ID: <4B83FA1C.8000902@marel.com> (raw)
In-Reply-To: <1266307868.11659.177.camel@localhost>
Any special reason this in MPC5121 Revision 2 only?
I did not see anything that contradicted the rev 3 manual in the code.
But there is one harmless bug (since the NFC_CMD_FAIL symbol is never used), i.e.
git diff
diff --git a/drivers/mtd/nand/mpc5121_nfc.c b/drivers/mtd/nand/mpc5121_nfc.c
index 191bf99..38a99ef 100644
--- a/drivers/mtd/nand/mpc5121_nfc.c
+++ b/drivers/mtd/nand/mpc5121_nfc.c
@@ -100,7 +100,7 @@
#define NFC_OUTPUT (1 << 3)
#define NFC_ID (1 << 4)
#define NFC_STATUS (1 << 5)
-#define NFC_CMD_FAIL (1 << 15)
+#define NFC_CMD_FAIL (1 << 14)
#define NFC_INT (1 << 15)
/* Bit Definitions: NFC_WRPROT */
The NAND chip is is detected (given that I disable the Revison check),
but the /dev7mtd0 is not accessable as block device. Is that normal?
The UBIFS also gives up I am assuming because the /dev/mtd0 is not block device.
rg
kd
On 02/16/2010 08:11 AM, Artem Bityutskiy wrote:
> On Mon, 2010-02-15 at 18:35 +0100, Anatolij Gustschin wrote:
>> Adds NAND Flash Controller driver for MPC5121 Revision 2.
>> All device features, except hardware ECC and power management,
>> are supported.
>>
>> Signed-off-by: Piotr Ziecik<kosmo@semihalf•com>
>> Signed-off-by: Wolfgang Denk<wd@denx•de>
>> Signed-off-by: Anatolij Gustschin<agust@denx•de>
>> Acked-by: Grant Likely<grant.likely@secretlab•ca>
>> Cc:<linux-mtd@lists•infradead.org>
>> Cc: Grant Likely<grant.likely@secretlab•ca>
>> Cc: John Rigby<jcrigby@gmail•com>
>> ---
>> Changes since v3:
>> - include 'asm/mpc5121.h' header instead of 'asm/mpc5xxx.h'.
>> This change is needed because arch patch adding reset
>> module definition was reworked and doesn't add mpc5121
>> specific definitions to common header for mpc52xx/mpc5121.
>>
>> Changes since v2:
>> - move the arch bits into separate patch
>> (it is the next patch in this series now)
>> - use __devinit/__devexit/__devexit_p and __devinitdata
>>
>> Changes since v1:
>> - add logfile with changes since previous version
>>
>> Changes since the patch version submitted in May 2009:
>>
>> - move mpc5121_nfc.h to the driver .c as there is only one user
>> - remove DRV_VERSION macro
>> - replace printk() by dev_*()
>> - drop unnecessary .suspend and .resume initializations
>> - remove duplicate .name/.owner settings
>> - fix mpc5121_nfc_init() to "return of_register_platform_driver(&mpc5121_nfc_driver);"
>> - move module_init() to just below the init function
>> - remove MODULE_VERSION
>> - use "mtd: Add MPC5121 NAND Flash Controller driver" as the subject,
>> previously it was "mpc5121: Added NAND Flash Controller driver.
>>
>> drivers/mtd/nand/Kconfig | 7 +
>> drivers/mtd/nand/Makefile | 1 +
>> drivers/mtd/nand/mpc5121_nfc.c | 916 ++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 924 insertions(+), 0 deletions(-)
>> create mode 100644 drivers/mtd/nand/mpc5121_nfc.c
>
> Pushed to my l2-mtd-2.6.git / dunno.
>
next prev parent reply other threads:[~2010-02-23 15:59 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 13:42 [PATCH v3 00/11] Update support for MPC512x Anatolij Gustschin
2010-02-05 13:42 ` [PATCH v3 01/11] powerpc/mpc5121: avoid using arch_initcall for clock init Anatolij Gustschin
2010-02-05 13:42 ` [PATCH v3 02/11] powerpc/mpc5121: Add machine restart support Anatolij Gustschin
2010-02-09 23:24 ` Wolfram Sang
2010-02-15 16:38 ` Anatolij Gustschin
2010-02-10 2:32 ` Grant Likely
2010-02-15 16:51 ` [PATCH v4 " Anatolij Gustschin
2010-02-15 20:58 ` Wolfram Sang
2010-02-05 13:42 ` [PATCH v3 03/11] rtc: Add MPC5121 Real time clock driver Anatolij Gustschin
2010-02-10 2:39 ` Grant Likely
2010-02-10 18:25 ` [rtc-linux] " Alessandro Zummo
2010-02-05 13:42 ` [PATCH v3 04/11] mtd: Add MPC5121 NAND Flash Controller driver Anatolij Gustschin
2010-02-10 2:42 ` Grant Likely
2010-03-30 13:15 ` Artem Bityutskiy
2010-02-15 17:35 ` [PATCH v4 " Anatolij Gustschin
2010-02-16 8:11 ` Artem Bityutskiy
2010-02-23 15:54 ` Kári Davíðsson [this message]
2010-02-05 13:42 ` [PATCH v3 05/11] powerpc/mpc5121: create and register NFC device Anatolij Gustschin
2010-02-05 13:42 ` [PATCH v3 06/11] dma: Add MPC512x DMA driver Anatolij Gustschin
2010-02-10 2:44 ` Grant Likely
2010-03-01 13:46 ` Anatolij Gustschin
2010-03-02 6:00 ` Dan Williams
2010-02-05 13:42 ` [PATCH v3 07/11] powerpc/fsl_soc.c: prepare for addition of mpc5121 USB code Anatolij Gustschin
2010-02-05 13:42 ` [PATCH v3 08/11] powerpc/mpc5121: add USB host support Anatolij Gustschin
2010-02-05 13:42 ` [PATCH v3 09/11] powerpc/mpc5121: shared DIU framebuffer support Anatolij Gustschin
2010-02-16 18:06 ` Grant Likely
2010-02-18 16:15 ` York Sun
2010-02-27 21:58 ` [PATCH 0/3] Rework MPC5121 DIU support (for 2.6.34) Anatolij Gustschin
2010-02-28 7:04 ` Grant Likely
2010-02-27 21:58 ` [PATCH 1/3] video: add support for getting video mode from device tree Anatolij Gustschin
2010-02-28 6:30 ` Grant Likely
2010-02-28 8:44 ` Mitch Bradley
2010-02-28 14:47 ` Grant Likely
2010-03-01 3:45 ` Benjamin Herrenschmidt
2010-04-28 13:43 ` Anatolij Gustschin
2010-05-19 21:19 ` Grant Likely
2010-02-27 21:58 ` [PATCH 2/3] fbdev: fsl-diu-fb.c: allow setting panel video mode from DT Anatolij Gustschin
2010-02-28 6:52 ` Grant Likely
2010-02-27 21:58 ` [PATCH 3/3] powerpc/mpc5121: shared DIU framebuffer support Anatolij Gustschin
2010-02-28 6:50 ` Grant Likely
2010-04-28 20:28 ` Anatolij Gustschin
2010-02-27 22:09 ` [PATCH v3 09/11] " Anatolij Gustschin
2010-02-05 13:42 ` [PATCH v3 10/11] powerpc/mpc5121: update mpc5121ads DTS Anatolij Gustschin
2010-02-16 18:11 ` Grant Likely
2010-02-16 19:32 ` [PATCH] powerpc: mpc5121: correct DIU compatible property Anatolij Gustschin
2010-02-16 19:51 ` Grant Likely
2010-02-05 13:42 ` [PATCH v3 11/11] powerpc/mpc5121: Add default config for MPC5121 Anatolij Gustschin
2010-02-09 8:48 ` [PATCH v3 00/11] Update support for MPC512x Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B83FA1C.8000902@marel.com \
--to=kari.davidsson@marel$(echo .)com \
--cc=agust@denx$(echo .)de \
--cc=dedekind1@gmail$(echo .)com \
--cc=dwmw2@infradead$(echo .)org \
--cc=dzu@denx$(echo .)de \
--cc=kosmo@semihalf$(echo .)com \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox