Subject: Re: [PATCH] powerpc: Fix lwsync feature fixup vs. modules on 64-bit

From: Sachin Sant <[email-masked]>
Date: Fri, 26 Feb 2010 18:40:36 +0530

Benjamin Herrenschmidt wrote:
> Anton's commit enabling the use of the lwsync fixup mechanism on 64-bit
> breaks modules. The lwsync fixup section uses .long instead of the
> FTR_ENTRY_OFFSET macro used by other fixups sections, and thus will
> generate 32-bit relocations that our module loader cannot resolve.
>
> This changes it to use the same type as other feature sections.
>
> Note however that we might want to consider using 32-bit for all the
> feature fixup offsets and add support for R_PPC_REL32 to module_64.c
> instead as that would reduce the size of the kernel image. I'll leave
> that as an exercise for the reader for now...
>
> Signed-off-by: Benjamin Herrenschmidt <[email-masked]>
> ---
>  arch/powerpc/include/asm/feature-fixups.h |    2 +-
>  arch/powerpc/lib/feature-fixups.c         |    3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>   
Thanks for the patch Ben.

I can boot -next on my power boxes with it.

thanks
-Sachin

-- 

---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------