From: Albert Herranz <albert_herranz@yahoo•es>
To: FUJITA Tomonori <fujita.tomonori@lab•ntt.co.jp>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: x86@kernel•org, linux-ia64@vger•kernel.org,
linux-usb@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH v4 05/11] swiotlb: add swiotlb_set_default_size()
Date: Tue, 16 Mar 2010 06:58:41 +0100 [thread overview]
Message-ID: <4B9F1E11.80201@yahoo.es> (raw)
In-Reply-To: <20100316104440Y.fujita.tomonori@lab.ntt.co.jp>
FUJITA Tomonori wrote:
> On Fri, 12 Mar 2010 20:12:40 +0100
> Albert Herranz <albert_herranz@yahoo•es> wrote:
>
>> The current SWIOTLB code uses a default of 64MB for the IO TLB area.
>> This size can be influenced using a kernel command line parameter "swiotlb".
>> Unfortunately, the parsing of the kernel command line is done _after_ the
>> swiotlb is initialized on some architectures.
>>
>> This patch adds a new function swiotlb_set_default_size() which can be used
>> before swiotlb_init() to indicate the desired IO TLB area size in bytes.
>>
>> This will be used later to implement a smaller IO TLB on the Nintendo Wii
>> video game console which just comes with 24MB + 64MB of RAM.
>>
>> CC: linuxppc-dev@lists•ozlabs.org
>> CC: linux-kernel@vger•kernel.org
>> CC: x86@kernel•org
>> CC: linux-ia64@vger•kernel.org
>> Signed-off-by: Albert Herranz <albert_herranz@yahoo•es>
>> ---
>> include/linux/swiotlb.h | 2 ++
>> lib/swiotlb.c | 20 ++++++++++++++++++++
>> 2 files changed, 22 insertions(+), 0 deletions(-)
>
> Please fix the powerpc swiotlb initialization instead.
>
> Calling swiotlb_init() before parsing kernel parameters sounds
> wrong. Any reasons why you can't fix it?
>
I think that this would be better asked by a PowerPC maintainer. Ben?
If this is really a problem the swiotlb late init may be a solution too in this particular case.
Thanks,
Albert
next prev parent reply other threads:[~2010-03-16 5:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 19:12 [PATCH v4 00/11] wii: add usb 2.0 support Albert Herranz
2010-03-12 19:12 ` [PATCH v4 01/11] powerpc: add per-device dma coherent support Albert Herranz
2010-03-12 19:12 ` [PATCH v4 02/11] powerpc: add min_direct_dma_addr Albert Herranz
2010-03-12 19:12 ` [PATCH v4 03/11] swiotbl: add back swiotlb_alloc_boot() Albert Herranz
2010-03-12 19:12 ` [PATCH v4 04/11] swiotlb: support NOT_COHERENT_CACHE PowerPC platforms Albert Herranz
2010-03-16 1:54 ` FUJITA Tomonori
2010-03-16 2:25 ` FUJITA Tomonori
2010-03-16 6:17 ` Albert Herranz
2010-03-16 6:09 ` Albert Herranz
2010-03-12 19:12 ` [PATCH v4 05/11] swiotlb: add swiotlb_set_default_size() Albert Herranz
2010-03-16 1:44 ` FUJITA Tomonori
2010-03-16 5:58 ` Albert Herranz [this message]
2010-03-16 10:08 ` FUJITA Tomonori
2010-03-16 19:28 ` Becky Bruce
2010-03-16 23:16 ` FUJITA Tomonori
2010-03-12 19:12 ` [PATCH v4 06/11] USB: refactor unmap_urb_for_dma/map_urb_for_dma Albert Herranz
2010-03-12 19:12 ` [PATCH v4 07/11] USB: add HCD_NO_COHERENT_MEM host controller driver flag Albert Herranz
2010-03-12 19:12 ` [PATCH v4 08/11] wii: have generic dma coherent Albert Herranz
2010-03-12 19:12 ` [PATCH v4 09/11] wii: add mem2 dma mapping ops Albert Herranz
2010-03-12 19:12 ` [PATCH v4 10/11] wii: enable swiotlb Albert Herranz
2010-03-12 19:12 ` [PATCH v4 11/11] wii: hollywood ehci controller support Albert Herranz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9F1E11.80201@yahoo.es \
--to=albert_herranz@yahoo$(echo .)es \
--cc=benh@kernel$(echo .)crashing.org \
--cc=fujita.tomonori@lab$(echo .)ntt.co.jp \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox