From: Mitch Bradley <wmb@firmworks•com>
To: Timur Tabi <timur@freescale•com>
Cc: Scott Wood <scottwood@freescale•com>,
devicetree-discuss@lists•ozlabs.org, linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powerpc/fsl: add device tree binding for QE firmware
Date: Fri, 26 Mar 2010 08:48:31 -1000 [thread overview]
Message-ID: <4BAD017F.6090109@firmworks.com> (raw)
In-Reply-To: <4BACFF7B.3010002@freescale.com>
Timur Tabi wrote:
> Grant Likely wrote:
>
>>> Without the compatible property, the only way I'd know that the child node contains a firmware is to look at the actual name of the child node, which (as Scott and I believe) is not better than a compatible property.
>>>
>> If it is always a child of a qe node, then I've got no objections.
>>
>
> I have no problem with putting the firmware node as a child of the QE node and skipping the phandle property, but only as long as there's only one QE node. Would you agree that this is bad:
>
> qe1: qe@e0080000 {
> compatible = "fsl,qe";
> qefw: fsl,qe_firmware {
> compatible="fsl,qe-firmware";
> fsl,firmware = /bininc/("firmware-blob.bin");
> fsl,qe-firmware-eccr = <0x00000000 0x00001230>;
> }
> ...
> }
>
> qe2: qe@e0090000 {
> compatible = "fsl,qe";
> fsl,firmware-phandle = <&qefw>;
> ...
> }
>
>
It not any worse than having the firmware blob anywhere else that is not
hierarchically related.
If one insists on purity of hierarchy, one could introduce a node above
qe1 and qe2 and put the firmware blob in that parent node. That
captures the assertion that the two qe devices are in fact identical so
the same firmware is suitable for both.
next prev parent reply other threads:[~2010-03-26 18:48 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 21:42 [PATCH] powerpc/fsl: add device tree binding for QE firmware Timur Tabi
2010-03-24 6:07 ` Grant Likely
2010-03-24 12:05 ` Timur Tabi
2010-03-24 17:00 ` Segher Boessenkool
2010-03-24 17:07 ` Grant Likely
2010-03-24 17:31 ` Timur Tabi
2010-03-24 18:10 ` Grant Likely
2010-03-24 18:21 ` Mitch Bradley
2010-03-24 18:25 ` Timur Tabi
2010-03-24 18:24 ` M. Warner Losh
2010-03-24 18:31 ` Timur Tabi
2010-03-25 1:49 ` Segher Boessenkool
2010-03-25 14:42 ` Timur Tabi
2010-03-25 16:10 ` Grant Likely
2010-03-25 16:34 ` Scott Wood
2010-03-25 16:46 ` Timur Tabi
2010-03-26 18:23 ` Rafal Jaworowski
2010-03-25 23:53 ` M. Warner Losh
2010-03-26 0:22 ` Timur Tabi
2010-03-25 15:16 ` Scott Wood
2010-03-25 15:29 ` Mitch Bradley
2010-03-25 16:16 ` Grant Likely
2010-03-25 16:36 ` Timur Tabi
2010-03-25 16:50 ` Scott Wood
2010-03-25 16:59 ` Grant Likely
2010-03-25 17:03 ` Timur Tabi
2010-03-25 17:35 ` Grant Likely
2010-03-25 18:05 ` Timur Tabi
2010-03-25 19:53 ` Scott Wood
2010-03-25 20:04 ` Timur Tabi
2010-03-25 21:54 ` Grant Likely
2010-03-25 22:19 ` Timur Tabi
2010-03-25 21:39 ` Grant Likely
2010-03-25 22:47 ` Scott Wood
2010-03-25 21:22 ` David Gibson
2010-03-26 1:26 ` Grant Likely
2010-03-26 15:17 ` Timur Tabi
2010-03-26 18:20 ` Grant Likely
2010-03-26 18:39 ` Timur Tabi
2010-03-26 18:44 ` Grant Likely
2010-03-26 18:48 ` Timur Tabi
2010-03-26 18:56 ` Grant Likely
2010-03-26 18:58 ` Mitch Bradley
2010-03-26 19:07 ` Grant Likely
2010-03-26 18:48 ` Mitch Bradley [this message]
2010-03-24 18:27 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAD017F.6090109@firmworks.com \
--to=wmb@firmworks$(echo .)com \
--cc=devicetree-discuss@lists$(echo .)ozlabs.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=scottwood@freescale$(echo .)com \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox