public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale•com>
To: Anton Vorontsov <avorontsov@mvista•com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH v4] powerpc: Add hibernation support for FSL BookE processors
Date: Mon, 17 May 2010 13:12:37 -0500	[thread overview]
Message-ID: <4BF18715.8050201@freescale.com> (raw)
In-Reply-To: <20100416190319.GA4104@oksana.dev.rtsoft.ru>

On 04/16/2010 02:03 PM, Anton Vorontsov wrote:
> +	/* restore the MSR */
> +	lwz	r3,SL_MSR(r11)
> +
> +	/* Restore TB */
> +	li	r3,0

Missing mtmsr?

Otherwise ACK.

-Scott

  parent reply	other threads:[~2010-05-17 18:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-24 21:38 [PATCH v2] powerpc: Add hibernation support for FSL BookE processors Anton Vorontsov
2010-04-15 18:45 ` Anton Vorontsov
2010-04-15 19:20   ` Kumar Gala
2010-04-15 19:36     ` Anton Vorontsov
2010-04-15 20:05     ` Scott Wood
2010-04-15 20:18       ` Scott Wood
2010-04-16 11:56         ` [PATCH v3] " Anton Vorontsov
2010-04-16 15:54           ` Scott Wood
2010-04-16 19:03             ` [PATCH v4] " Anton Vorontsov
2010-05-17 18:03               ` Kumar Gala
2010-05-17 18:12               ` Scott Wood [this message]
2010-05-17 18:56                 ` [PATCH v5] " Anton Vorontsov
2010-05-17 21:17                   ` Kumar Gala
2010-05-17 21:22                   ` Kumar Gala
2010-05-18  5:59                     ` Anton Vorontsov
2010-04-16  5:40       ` [PATCH v2] " Anton Vorontsov
2010-04-16 15:48         ` Scott Wood
2010-04-16 19:03           ` Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF18715.8050201@freescale.com \
    --to=scottwood@freescale$(echo .)com \
    --cc=avorontsov@mvista$(echo .)com \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox