From: Gary Thomas <gary@mlbassoc•com>
To: hellohello <hellohello008@163•com>
Cc: Scott Wood <scottwood@freescale•com>, linuxppc-dev@lists•ozlabs.org
Subject: Re: Problem of PowerPc 82xx when using smc
Date: Fri, 21 May 2010 05:20:43 -0600 [thread overview]
Message-ID: <4BF66C8B.10407@mlbassoc.com> (raw)
In-Reply-To: <051501caf896$5c954630$a51cbcc0@sfdomain.com>
On 05/20/2010 09:33 PM, hellohello wrote:
>> No, it shouldn't -- rx_bd_base is of type "cbd_t *", so the multiplication
>> already happens as part of pointer arithmetic.
> ---Yes, you are right. I made a basic mistake.
>
> But now I have another question.
> The SMC1 params can be relocated to any offset of the DPRAM on a 64 byte boundary, not as the SCC1, which must be at 0x8000 offset of the DPRAM.
> The SMC1 params base is set at 0x87FC offset of the DPRAM.
>
> So if I want SMC1 params start at 0x200 in DPRAM , I should set 0x200 to the 0x87FC offset of the DPRAM.
> I have see this code in u-boot, but I can not find this code in neither cpm_uart_cpm2.c nor cpm_uart_core.c.
>
> Should I add these code to cpm_uart_core.c?
>
> --dp_mem = cpm_dpram_addr(0x87fc);
> --out_be16(dp_mem, SMC1_BASE);
Why are you mucking about with this code at all? SMCx serial certainly
works on every platform I've ever used, 8xx and 8xxx as well.
> ----- Original Message -----
> From: "Scott Wood"<scottwood@freescale•com>
> To: "hellohello"<hellohello008@163•com>
> Cc:<linuxppc-dev@lists•ozlabs.org>
> Sent: Friday, May 21, 2010 1:06 AM
> Subject: Re: Problem of PowerPc 82xx when using smc
>
>
>> On Thu, May 20, 2010 at 04:58:27PM +0800, hellohello wrote:
>>>
>>> I find a problem in
>>> drivers/serial/cpm_uart/cpm_uart_cpm2.c:
>>> int cpm_uart_allocbuf(struct uart_cpm_port *pinfo, unsigned int is_con)
>>> {
>>> ... ...
>>> pinfo->tx_bd_base = pinfo->rx_bd_base + pinfo->rx_nrfifos;
>>> /*The above line should be ：*/
>>> pinfo->tx_bd_base = pinfo->rx_bd_base + sizeof(cbd_t) * pinfo->rx_nrfifos;
>>
>> No, it shouldn't -- rx_bd_base is of type "cbd_t *", so the multiplication
>> already happens as part of pointer arithmetic.
>>
>>> return 0;
>>> }
>>>
>>> Where to get the newest code for kernel?
>>
>> git.kernel.org
>>
>>> How to know whether it is already patched by anyone else? Just search in this mail list?
>>
>> As well as the current git tree.
>>
>> -Scott
>> _______________________________________________
>> Linuxppc-dev mailing list
>> Linuxppc-dev@lists•ozlabs.org
>> https://lists.ozlabs.org/listinfo/linuxppc-dev
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists•ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
next prev parent reply other threads:[~2010-05-21 11:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 8:58 Problem of PowerPc 82xx when using smc hellohello
2010-05-20 17:06 ` Scott Wood
2010-05-21 3:33 ` hellohello
2010-05-21 11:20 ` Gary Thomas [this message]
2010-05-22 3:37 ` hellohello
2010-05-21 17:28 ` Scott Wood
2010-05-22 2:51 ` hellohello
-- strict thread matches above, loose matches on Subject: below --
2010-05-22 6:23 hellohello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF66C8B.10407@mlbassoc.com \
--to=gary@mlbassoc$(echo .)com \
--cc=hellohello008@163$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox