From: Scott Wood <scottwood@freescale•com>
To: kerstin jonsson <kerstin.jonsson@ericsson•com>
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: fsl_rio.c build problem
Date: Fri, 04 Jun 2010 15:04:35 -0500 [thread overview]
Message-ID: <4C095C53.60002@freescale.com> (raw)
In-Reply-To: <4C08E25E.8000200@ericsson.com>
On 06/04/2010 06:24 AM, kerstin jonsson wrote:
> Hi,
>
> I'm using:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
>
> and building for ARCH=powerpc - mpc85xx_defconfig
>
> arch/powerpc/sysdev/fsl_rio.c will not build due to a missing
> MCSR_MASK bitmask definition.
>
> The attached patch is based on code found in
>
> git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git
>
> and - at the least - will fix the build problem.
Can we remove the use of MCSR_MASK from fsl_rio.c instead? I don't see
what it's accomplishing here. MCSR_MASK will be wrong on e500mc, so
exporting it as something that looks generic doesn't seem right.
MCSR_BUS_RBERR also needs to change on e500mc -- you'll probably get
MCSR_LDG.
-Scott
next prev parent reply other threads:[~2010-06-04 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 11:24 fsl_rio.c build problem kerstin jonsson
2010-06-04 20:04 ` Scott Wood [this message]
2010-06-06 16:20 ` kerstin jonsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C095C53.60002@freescale.com \
--to=scottwood@freescale$(echo .)com \
--cc=kerstin.jonsson@ericsson$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox