From: Avi Kivity <avi@redhat•com>
To: Alexander Graf <agraf@suse•de>
Cc: linuxppc-dev@lists•ozlabs.org, kvm@vger•kernel.org,
kvm-ppc@vger•kernel.org
Subject: Re: [PATCH 1/2] KVM: PPC: Add generic hpte management functions
Date: Tue, 22 Jun 2010 15:07:49 +0300 [thread overview]
Message-ID: <4C20A795.6040607@redhat.com> (raw)
In-Reply-To: <4C20A6C8.4070002@suse.de>
On 06/22/2010 03:04 PM, Alexander Graf wrote:
> Avi Kivity wrote:
>
>> On 06/21/2010 04:44 PM, Alexander Graf wrote:
>>
>>> Currently the shadow paging code keeps an array of entries it knows
>>> about.
>>> Whenever the guest invalidates an entry, we loop through that entry,
>>> trying to invalidate matching parts.
>>>
>>> While this is a really simple implementation, it is probably the most
>>> ineffective one possible. So instead, let's keep an array of lists
>>> around
>>> that are indexed by a hash. This way each PTE can be added by 4
>>> list_add,
>>> removed by 4 list_del invocations and the search only needs to loop
>>> through
>>> entries that share the same hash.
>>>
>>> This patch implements said lookup and exports generic functions that
>>> both
>>> the 32-bit and 64-bit backend can use.
>>>
>>>
>> Mind explaining the all list in there?
>>
> The all list is used to flush all entries when we need to get rid of all
> entries, for example when we write a BAT.
>
>
Yes, I more or less gathered that when I saw patch 2. Does it make
sense to avoid it by looping over all vpte lists in the vpte hash? More
effort for a full flush, esp. when the mmu is sparse, but less for
individual pte operations.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-06-22 12:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 13:44 [PATCH 1/2] KVM: PPC: Add generic hpte management functions Alexander Graf
2010-06-21 13:44 ` [PATCH 2/2] KVM: PPC: Make use of hash based Shadow MMU Alexander Graf
2010-06-22 12:02 ` [PATCH 1/2] KVM: PPC: Add generic hpte management functions Avi Kivity
2010-06-22 12:04 ` Alexander Graf
2010-06-22 12:07 ` Avi Kivity [this message]
2010-06-22 12:10 ` Alexander Graf
2010-06-22 12:12 ` Avi Kivity
2010-06-22 12:14 ` Alexander Graf
2010-06-22 12:20 ` Avi Kivity
2010-06-26 22:58 ` Benjamin Herrenschmidt
2010-06-27 7:53 ` Avi Kivity
2010-06-27 22:10 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2010-06-30 13:18 [PATCH 0/2] Faster MMU lookups for Book3s v3 Alexander Graf
2010-06-30 13:18 ` [PATCH 1/2] KVM: PPC: Add generic hpte management functions Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C20A795.6040607@redhat.com \
--to=avi@redhat$(echo .)com \
--cc=agraf@suse$(echo .)de \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox