From: Chuck Meade <chuck@ThePTRGroup•com>
To: Fushen Chen <fchen@apm•com>
Cc: linuxppc-dev@ozlabs•org, chuck@theptrgroup•com,
linux-usb@vger•kernel.org, Mark Miesfeld <mmiesfeld@apm•com>,
gregkh@suse•de
Subject: Re: [PATCH 1/9 v1.01] Add Synopsys DesignWare HS USB OTG Controller driver.
Date: Tue, 13 Jul 2010 18:16:26 -0400 [thread overview]
Message-ID: <4C3CE5BA.5060302@ThePTRGroup.com> (raw)
In-Reply-To: <12789766042434-git-send-email-fchen@apm.com>
On 07/12/2010 07:16 PM, Fushen Chen wrote:
> The DWC OTG driver module provides the initialization and cleanup
> entry points for the DWC OTG USB driver.
>
> Signed-off-by: Fushen Chen <fchen@apm•com>
> Signed-off-by: Mark Miesfeld <mmiesfeld@apm•com>
> ---
This reply is to the patch series, not just this 1/9 patch section.
Fushen, why did you pick and choose which fixes to incorporate from the Denx
tree's version of the dwc_otg driver?
I'm not taking the time here to go through this multipart patch and check that
you incorporated every fix, but I *did* randomly pick one fix that I made to that
driver, to see if you incorporated it, and it appears you did not.
I would have expected that you would have incorporated the fixes that were made
to this driver in the Denx tree.
The one that I checked is in the data toggle error interrupt handling, in
handle_hc_chhltd_intr_dma() (see your 5/9 email in this patch series). It looks
like you left out the fix I made to this logic that averts an interrupt storm.
I assume that since I checked one particular fix, and it was missing from your
patch series, that there are likely more fixes you omitted. Can you explain why
you would leave this out, after Stefan asked you to incorporate the code changes
made in the Denx tree's version of the driver?
Chuck
next prev parent reply other threads:[~2010-07-13 22:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 23:16 [PATCH 1/9 v1.01] Add Synopsys DesignWare HS USB OTG Controller driver Fushen Chen
2010-07-12 23:16 ` [PATCH 2/9 " Fushen Chen
2010-07-12 23:16 ` [PATCH 3/9 " Fushen Chen
2010-07-12 23:16 ` [PATCH 4/9 " Fushen Chen
2010-07-12 23:16 ` [PATCH 5/9 " Fushen Chen
2010-07-12 23:16 ` [PATCH 6/9 " Fushen Chen
2010-07-12 23:16 ` [PATCH 7/9 " Fushen Chen
2010-07-12 23:16 ` [PATCH 8/9 " Fushen Chen
2010-07-12 23:16 ` [PATCH 9/9 " Fushen Chen
2010-07-12 23:55 ` [PATCH 1/9 " David Brownell
2010-07-13 22:13 ` fushen chen
2010-07-13 22:50 ` David Brownell
2010-07-13 22:16 ` Chuck Meade [this message]
2010-07-13 23:02 ` Feng Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3CE5BA.5060302@ThePTRGroup.com \
--to=chuck@theptrgroup$(echo .)com \
--cc=fchen@apm$(echo .)com \
--cc=gregkh@suse$(echo .)de \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mmiesfeld@apm$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox