Subject: Re: [PATCH 7/8] v3 Define memory_block_size_bytes() for ppc/pseries

From: Brian King <[email-masked]>
Date: Wed, 21 Jul 2010 15:27:19 -0500

On 07/19/2010 10:59 PM, Nathan Fontenot wrote:
> 
> +static u32 get_memblock_size(void)
> +{
> +	struct device_node *np;
> +	unsigned int memblock_size = 0;
> +
> +	np = of_find_node_by_path("/ibm,dynamic-reconfiguration-memory");
> +	if (np) {
> +		const unsigned int *size;

This needs to be an unsigned long, otherwise I always get zero on my p6.

> +
> +		size = of_get_property(np, "ibm,lmb-size", NULL);
> +		memblock_size = size ? *size : 0;
> +
> +		of_node_put(np);

-- 
Brian King
Linux on Power Virtualization
IBM Linux Technology Center