From: Jason Wessel <jason.wessel@windriver•com>
To: Michal Simek <monstr@monstr•eu>
Cc: KGDB Mailing List <kgdb-bugreport@lists•sourceforge.net>,
linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powerpc: Replace hardcoded offset by BREAK_INSTR_SIZE
Date: Wed, 28 Jul 2010 06:16:51 -0500 [thread overview]
Message-ID: <4C5011A3.3020501@windriver.com> (raw)
In-Reply-To: <1280308724-8402-1-git-send-email-monstr@monstr.eu>
On 07/28/2010 04:18 AM, Michal Simek wrote:
> kgdb_handle_breakpoint checks the first arch_kgdb_breakpoint
> which is not known by gdb that's why is necessary jump over
> it. The jump lenght is equal to BREAK_INSTR_SIZE that's
> why is cleaner to use defined macro instead of hardcoded
> non-described offset.
>
>
Seems fine to me. I'll add this to the kgdb merge queue for 2.6.36.
Jason.
> Signed-off-by: Michal Simek <monstr@monstr•eu>
> CC: Jason Wessel <jason.wessel@windriver•com>
> CC: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> CC: linuxppc-dev@ozlabs•org
> ---
> arch/powerpc/kernel/kgdb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c
> index 82a7b22..7f61a3a 100644
> --- a/arch/powerpc/kernel/kgdb.c
> +++ b/arch/powerpc/kernel/kgdb.c
> @@ -129,7 +129,7 @@ static int kgdb_handle_breakpoint(struct pt_regs *regs)
> return 0;
>
> if (*(u32 *) (regs->nip) == *(u32 *) (&arch_kgdb_ops.gdb_bpt_instr))
> - regs->nip += 4;
> + regs->nip += BREAK_INSTR_SIZE;
>
> return 1;
> }
>
next prev parent reply other threads:[~2010-07-28 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 9:18 [PATCH] powerpc: Replace hardcoded offset by BREAK_INSTR_SIZE Michal Simek
2010-07-28 11:16 ` Jason Wessel [this message]
2010-07-30 12:26 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5011A3.3020501@windriver.com \
--to=jason.wessel@windriver$(echo .)com \
--cc=kgdb-bugreport@lists$(echo .)sourceforge.net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=monstr@monstr$(echo .)eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox