Subject: Re: [PATCH] powerpc: Replace hardcoded offset by BREAK_INSTR_SIZE

From: Jason Wessel <[email-masked]>
Date: Wed, 28 Jul 2010 06:16:51 -0500

On 07/28/2010 04:18 AM, Michal Simek wrote:
> kgdb_handle_breakpoint checks the first arch_kgdb_breakpoint
> which is not known by gdb that's why is necessary jump over
> it. The jump lenght is equal to BREAK_INSTR_SIZE that's
> why is cleaner to use defined macro instead of hardcoded
> non-described offset.
>
>   
Seems fine to me.  I'll add this to the kgdb merge queue for 2.6.36.

Jason.

> Signed-off-by: Michal Simek <[email-masked]>
> CC: Jason Wessel <[email-masked]>
> CC: Benjamin Herrenschmidt <[email-masked]>
> CC: [email-masked]
> ---
>  arch/powerpc/kernel/kgdb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c
> index 82a7b22..7f61a3a 100644
> --- a/arch/powerpc/kernel/kgdb.c
> +++ b/arch/powerpc/kernel/kgdb.c
> @@ -129,7 +129,7 @@ static int kgdb_handle_breakpoint(struct pt_regs *regs)
>  		return 0;
>  
>  	if (*(u32 *) (regs->nip) == *(u32 *) (&arch_kgdb_ops.gdb_bpt_instr))
> -		regs->nip += 4;
> +		regs->nip += BREAK_INSTR_SIZE;
>  
>  	return 1;
>  }
>