Subject: Re: [PATCH] char: hvc: check for error case

From: Chris Metcalf <[email-masked]>
Date: Mon, 13 Sep 2010 09:12:53 -0400

On 9/12/2010 2:57 PM, Vasiliy Kulikov wrote:
> hvc_alloc() may fail, if so exit from init() with error.
>
> Signed-off-by: Vasiliy Kulikov <[email-masked]>

Thanks, accepted into my tree (for the next merge window).  In practice all
this means is in debug mode we'll get a warning from do_one_initcall()
rather than silence, but you're right, it's technically better. :-)

> ---
>  I cannot compile this driver at all, so it is not tested.
>
>  drivers/char/hvc_tile.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/hvc_tile.c b/drivers/char/hvc_tile.c
> index c4efb55..7a84a05 100644
> --- a/drivers/char/hvc_tile.c
> +++ b/drivers/char/hvc_tile.c
> @@ -61,7 +61,8 @@ console_initcall(hvc_tile_console_init);
>  
>  static int __init hvc_tile_init(void)
>  {
> -	hvc_alloc(0, 0, &hvc_tile_get_put_ops, 128);
> -	return 0;
> +	struct hvc_struct *s;
> +	s = hvc_alloc(0, 0, &hvc_tile_get_put_ops, 128);
> +	return IS_ERR(s) ? PTR_ERR(s) : 0;
>  }
>  device_initcall(hvc_tile_init);

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com