From: Dan Williams <dan.j.williams@intel•com>
To: "tmarri@apm•com" <tmarri@apm•com>
Cc: "neilb@suse•de" <neilb@suse•de>,
"yur@emcraft•com" <yur@emcraft•com>,
"linux-raid@vger•kernel.org" <linux-raid@vger•kernel.org>,
"herbert@gondor•hengli.com.au" <herbert@gondor•hengli.com.au>,
"linux-crypto@vger•kernel.org" <linux-crypto@vger•kernel.org>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c
Date: Thu, 23 Sep 2010 13:22:03 -0700 [thread overview]
Message-ID: <4C9BB6EB.7020802@intel.com> (raw)
In-Reply-To: <1284774145-14543-1-git-send-email-tmarri@apm.com>
On 9/17/2010 6:42 PM, tmarri@apm•com wrote:
> From: Tirumala Marri<tmarri@apm•com>
>
> This patch generalizes the existing drver/dma/ppc4xx/adma.c, so that
> common code can be shared between different similar DMA engine
> drivers in other SoCs.
>
> Signed-off-by: Tirumala R Marri<tmarri@apm•com>
> ---
> drivers/dma/ppc4xx/adma.c | 4370 +++-----------------------------------
> drivers/dma/ppc4xx/adma.h | 116 +-
> drivers/dma/ppc4xx/ppc4xx-adma.h | 4020 +++++++++++++++++++++++++++++++++++
> 3 files changed, 4357 insertions(+), 4149 deletions(-)
> create mode 100644 drivers/dma/ppc4xx/ppc4xx-adma.h
>
Will both versions of this driver exist in the same kernel build? For
example the iop-adma driver supports iop13xx and iop3xx, but we select
the archtitecture at build time? Or, as I assume in this case, will the
two (maybe more?) ppc4xx adma drivers all be built in the same image,
more like ioatdma?
In the latter case I would recommend a file structure like:
drivers/dma/ppc4xx/adma.c
drivers/dma/ppc4xx/adma_440spe.c
drivers/dma/ppc4xx/adma_460ex.c
With patches to move the chipset specific pieces to their own file.
Minimizing the code churn in adma.c, or at least showing a progression
of what is unique and needs to be moved.
This would be similar to how ioatdma is structured and compiles a single
driver to cover the three major hardware revisions.
--
Dan
next prev parent reply other threads:[~2010-09-23 20:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-18 1:42 [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c tmarri
2010-09-18 21:09 ` Wolfgang Denk
2010-09-20 18:00 ` Tirumala Marri
2010-09-20 21:31 ` Wolfgang Denk
2010-09-19 20:00 ` Ilya Yanok
2010-09-21 16:51 ` Tirumala Marri
2010-09-23 20:22 ` Dan Williams [this message]
2010-09-23 22:39 ` Tirumala Marri
2010-09-24 6:58 ` Stefan Roese
2010-09-24 18:52 ` Tirumala Marri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9BB6EB.7020802@intel.com \
--to=dan.j.williams@intel$(echo .)com \
--cc=herbert@gondor$(echo .)hengli.com.au \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-raid@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=neilb@suse$(echo .)de \
--cc=tmarri@apm$(echo .)com \
--cc=yur@emcraft$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox