From: Mitch Bradley <wmb@firmworks•com>
To: Anton Vorontsov <cbouatmailru@gmail•com>
Cc: linuxppc-dev@ozlabs•org, devicetree-discuss@ozlabs•org
Subject: Re: [PATCH 2/2] powerpc: pcm030/032: add pagesize to dts
Date: Mon, 15 Nov 2010 11:06:44 -1000 [thread overview]
Message-ID: <4CE1A0E4.5030505@firmworks.com> (raw)
In-Reply-To: <20101115173250.GA22104@oksana.dev.rtsoft.ru>
On 11/15/2010 7:32 AM, Anton Vorontsov wrote:
> On Mon, Nov 15, 2010 at 06:25:16PM +0100, Wolfram Sang wrote:
>> Signed-off-by: Wolfram Sang<w.sang@pengutronix•de>
>> ---
>> arch/powerpc/boot/dts/pcm030.dts | 1 +
>> arch/powerpc/boot/dts/pcm032.dts | 3 ++-
>> 2 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/powerpc/boot/dts/pcm030.dts b/arch/powerpc/boot/dts/pcm030.dts
>> index 8a4ec30..e7c36bc 100644
>> --- a/arch/powerpc/boot/dts/pcm030.dts
>> +++ b/arch/powerpc/boot/dts/pcm030.dts
>> @@ -259,6 +259,7 @@
>> eeprom@52 {
>> compatible = "catalyst,24c32";
>> reg =<0x52>;
>> + pagesize =<32>;
>
> I think you'd better drop the pagesize property altogether, and
> instead make the compatible string more specific (if needed at
> all. are there any 'catalyst,24c32' chips with pagesize != 32?)
Microchip makes a 24c32 part that looks pretty similar to the catalyst
part, but Microchip's has a 64-byte page size compared to Catalyst's 32.
It would probably be feasible to have a generic I2C EEPROM driver that
could handle many different parts, parameterized by total size, block
size, and page size.
>
> Thanks,
>
next prev parent reply other threads:[~2010-11-15 21:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 17:25 [PATCH 1/2] misc: at24: parse OF-data, too Wolfram Sang
2010-11-15 17:25 ` [PATCH 2/2] powerpc: pcm030/032: add pagesize to dts Wolfram Sang
2010-11-15 17:32 ` Anton Vorontsov
2010-11-15 21:06 ` Mitch Bradley [this message]
2010-11-15 21:24 ` Anton Vorontsov
2010-11-15 21:58 ` Grant Likely
2010-11-15 22:17 ` Mitch Bradley
2010-11-15 22:30 ` David Gibson
2010-11-15 22:11 ` Wolfram Sang
2010-11-16 21:45 ` Wolfram Sang
2010-11-16 22:03 ` Anton Vorontsov
2010-11-15 21:41 ` [PATCH 1/2] misc: at24: parse OF-data, too Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE1A0E4.5030505@firmworks.com \
--to=wmb@firmworks$(echo .)com \
--cc=cbouatmailru@gmail$(echo .)com \
--cc=devicetree-discuss@ozlabs$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox