From: Sergei Shtylyov <sshtylyov@mvista•com>
To: Tejun Heo <tj@kernel•org>, Roman Fietze <roman.fietze@telemotive•de>
Cc: linux-ide@vger•kernel.org, linuxppc-dev@lists•ozlabs.org
Subject: Re: PowerPC MPC5200B ATA MWDMA regression
Date: Mon, 03 Jan 2011 19:33:17 +0300 [thread overview]
Message-ID: <4D21FA4D.3030506@mvista.com> (raw)
In-Reply-To: <4D21EAF1.2010504@ru.mvista.com>
Hello.
On 03-01-2011 18:27, Sergei Shtylyov wrote:
>>>> The commit you bisected to contains all those conversions too. Take a
>>>> look at a similar driver and look at how it has been converted
>>>> recently. Even better, just send the driver upstream. :-)
>>> It's already there...
>> Ouch, did I forget to convert
> It probably wasn't obvious as this driver had lived in non-BMDMA section of
> Kconfig before the recent patch:
> http://marc.info/?l=linux-ide&m=129303304605907
>> it or was it a merge timing problem?
>> Anyways, sorry about that. Please go ahead and fix it. :-)
Looks like the commit that added DMA support should be thanked for the
mischief:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=6b61e69e7bc1cfe80ab54c6321f19061f9487ed3
WBR, Sergei
next prev parent reply other threads:[~2011-01-03 16:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 13:45 PowerPC MPC5200B ATA MWDMA regression Roman Fietze
2011-01-03 13:59 ` Tejun Heo
2011-01-03 14:29 ` Sergei Shtylyov
2011-01-03 14:33 ` Tejun Heo
2011-01-03 15:27 ` Sergei Shtylyov
2011-01-03 16:33 ` Sergei Shtylyov [this message]
2011-01-09 22:48 ` [PATCH #upstream-fixes] pata_mpc52xx: inherit from ata_bmdma_port_ops Tejun Heo
2011-01-10 7:26 ` Roman Fietze
2011-01-19 1:00 ` Jeff Garzik
2011-01-03 14:34 ` PowerPC MPC5200B ATA MWDMA regression Roman Fietze
2011-01-03 14:27 ` acrux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D21FA4D.3030506@mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=linux-ide@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=roman.fietze@telemotive$(echo .)de \
--cc=tj@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox