From: Sergei Shtylyov <sshtylyov@mvista•com>
To: Xulei <B33228@freescale•com>
Cc: jgarzik@pobox•com, kumar.gala@freescale•com,
linuxppc-dev@lists•ozlabs.org, linux-ide@vger•kernel.org
Subject: Re: [PATCH] ATA: Add FSL sata v2 controller support
Date: Mon, 17 Jan 2011 14:47:58 +0300 [thread overview]
Message-ID: <4D342C6E.6000608@ru.mvista.com> (raw)
In-Reply-To: <1295248259-14752-1-git-send-email-B33228@freescale.com>
Hello.
On 17-01-2011 10:10, Xulei wrote:
> In FSL sata v2 block, the snoop bit of PRDT Word3 description
> information is at bit28 instead of bit22.
> This patch adds FSL sata v2 probe and resolve this difference.
> Signed-off-by: Xulei <B33228@freescale•com>
AFAIK, full name is required.
> Signed-off-by: Roy Zang <tie-fei.zang@freescale•com>
[...]
> diff --git a/arch/powerpc/boot/dts/p1022ds.dts b/arch/powerpc/boot/dts/p1022ds.dts
> index 2bbecbb..9ad41dd 100644
> --- a/arch/powerpc/boot/dts/p1022ds.dts
> +++ b/arch/powerpc/boot/dts/p1022ds.dts
> @@ -475,14 +475,14 @@
> };
>
> sata@18000 {
> - compatible = "fsl,mpc8536-sata", "fsl,pq-sata";
> + compatible = "fsl,p1022-sata", "fsl,pq-sata-v2";
> reg =<0x18000 0x1000>;
> cell-index =<1>;
> interrupts =<74 0x2>;
> };
>
> sata@19000 {
> - compatible = "fsl,mpc8536-sata", "fsl,pq-sata";
> + compatible = "fsl,p1022-sata", "fsl,pq-sata-v2";
> reg =<0x19000 0x1000>;
> cell-index =<2>;
> interrupts =<41 0x2>;
Please put this into the separate patch and push thru the PPC tree.
> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
> index b0214d0..a56399a 100644
> --- a/drivers/ata/sata_fsl.c
> +++ b/drivers/ata/sata_fsl.c
[...]
> @@ -417,7 +420,8 @@ static void sata_fsl_qc_prep(struct ata_queued_cmd *qc)
>
> if (qc->flags& ATA_QCFLAG_DMAMAP)
> num_prde = sata_fsl_fill_sg(qc, (void *)cd,
> - &ttl_dwords, cd_paddr);
> + &ttl_dwords, cd_paddr,
> + host_priv->data_snoop);
Please align these lines uniformly.
WBR, Sergei
next prev parent reply other threads:[~2011-01-17 11:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 7:10 [PATCH] ATA: Add FSL sata v2 controller support Xulei
2011-01-17 11:47 ` Sergei Shtylyov [this message]
2011-01-17 11:58 ` Aggrwal Poonam-B10812
2011-01-17 14:57 ` Kumar Gala
2011-01-18 3:01 ` Zang Roy-R61911
2011-01-18 11:27 ` Sergei Shtylyov
2011-01-18 11:43 ` Zang Roy-R61911
2011-01-18 12:33 ` Sergei Shtylyov
2011-01-19 1:10 ` Jeff Garzik
2011-01-19 5:23 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D342C6E.6000608@ru.mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=B33228@freescale$(echo .)com \
--cc=jgarzik@pobox$(echo .)com \
--cc=kumar.gala@freescale$(echo .)com \
--cc=linux-ide@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox