Subject: Re: [PATCH V9 09/10] USB/ppc4xx:Synopsys DWC OTG driver enable gadget support

From: Sergei Shtylyov <[email-masked]>
Date: Tue, 08 Feb 2011 15:44:46 +0300

Hello.

On 08.02.2011 1:54, [email-masked] wrote:

> From: Tirumala Marri<[email-masked]>

> Enable gadget support

> Signed-off-by: Tirumala R Marri<[email-masked]>
> Signed-off-by: Fushen Chen<[email-masked]>
> Signed-off-by: Mark Miesfeld<[email-masked]>
> ---
>   drivers/usb/gadget/Kconfig        |   22 ++++++++++++++++++++++
>   drivers/usb/gadget/gadget_chips.h |    9 +++++++++
>   2 files changed, 31 insertions(+), 0 deletions(-)

> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 5df8a8d..de7c10b 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -365,6 +365,28 @@ config USB_GADGET_MUSB_HDRC
>   	  This OTG-capable silicon IP is used in dual designs including
>   	  the TI DaVinci, OMAP 243x, OMAP 343x, TUSB 6010, and ADI Blackfin
>
> +# dwc_otg builds in ../dwc_otg along with host support
> +config USB_GADGET_DWC_HDRC
> +	boolean "DesignWare USB Peripheral"
> +	depends on DWC_OTG_MODE || DWC_DEVICE_ONLY

    Patch 10 should precede this one as it defines DWC_OTG_MODE and 
DWC_DEVICE_ONLY.

> +	select USB_GADGET_DUALSPEED
> +	select USB_GADGET_SELECTED
> +	select USB_GADGET_DWC_OTG
> +	help
> +	This OTG-capable Designware USB IP
> +
> +config USB_GADGET_DWC_OTG
> +	boolean "OTG Support"
> +	depends on USB_GADGET_DWC_HDRC

    What's the point of this option if it gets auto-selected by 
USB_GADGET_DWC_HDRC anyway?

WBR, Sergei