Subject: Re: [PATCH 5/5] xhci: Remove recursive call to xhci_handle_event

From: Sergei Shtylyov <[email-masked]>
Date: Fri, 25 Mar 2011 15:48:43 +0300

Hello.

On 25-03-2011 10:44, Matt Evans wrote:

> Make the caller loop while there are events to handle, instead.

> Signed-off-by: Matt Evans<[email-masked]>
> ---
>   drivers/usb/host/xhci-ring.c |   16 +++++++++-------
>   1 files changed, 9 insertions(+), 7 deletions(-)

> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index b46efd9..97bedd6 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
[...]
> @@ -2277,7 +2279,7 @@ hw_died:
>   	/* FIXME this should be a delayed service routine
>   	 * that clears the EHB.
>   	 */
> -	xhci_handle_event(xhci);
> +	while (xhci_handle_event(xhci)) {};

    Semicolon not needed after }. Perhaps the committer could change this...

WBR, Sergei