Subject: Re: [PATCH v10 09/10] USB/ppc4xx:Synopsys DWC OTG driver enable gadget support

From: Sergei Shtylyov <[email-masked]>
Date: Tue, 29 Mar 2011 15:53:24 +0400

Hello.

On 28-03-2011 22:28, [email-masked] wrote:

> From: Tirumala Marri <[email-masked]>

> Enable gadget support

> Signed-off-by: Tirumala R Marri <[email-masked]>
> Signed-off-by: Fushen Chen <[email-masked]>
> Signed-off-by: Mark Miesfeld <[email-masked]>
[...]

> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index bc5123c..61aca75 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -365,6 +365,28 @@ config USB_GADGET_MUSB_HDRC
>   	  This OTG-capable silicon IP is used in dual designs including
>   	  the TI DaVinci, OMAP 243x, OMAP 343x, TUSB 6010, and ADI Blackfin
>
> +# dwc_otg builds in ../dwc_otg along with host support

    There's no ../dwc_otg any longer.

> +config USB_GADGET_DWC_HDRC
> +	boolean "DesignWare USB Peripheral"
> +	depends on DWC_OTG_MODE || DWC_DEVICE_ONLY
> +	select USB_GADGET_DUALSPEED
> +	select USB_GADGET_SELECTED
> +	select USB_GADGET_DWC_OTG
> +	help
> +	This OTG-capable Designware USB IP
> +
> +config USB_GADGET_DWC_OTG
> +	boolean "OTG Support"
> +	depends on USB_GADGET_DWC_HDRC

    Not on DWC_OTG_MODE? How this option is different from DWC_OTG_MODE?

> +	help
> +	The most notable feature of USB OTG is support for a
> +	"Dual-Role" device, which can act as either a device
> +	or a host.  The initial role choice can be changed
> +	later, when two dual-role devices talk to each other.
> +	Select this only if your board has a Mini-AB connector.
> +
> +
> +

     Too many empty lines.

>   config USB_GADGET_M66592
>   	boolean "Renesas M66592 USB Peripheral Controller"
>   	select USB_GADGET_DUALSPEED

WBR, Sergei