From: Sergei Shtylyov <sshtylyov@mvista•com>
To: Tirumala Marri <tmarri@apm•com>
Cc: greg@kroah•com, linux-usb@vger•kernel.org,
Mark Miesfeld <mmiesfeld@apm•com>,
Keshava Munegowda <keshava_mgowda@ti•com>,
linuxppc-dev@lists•ozlabs.org, Fushen Chen <fchen@apm•com>
Subject: Re: [PATCH v10 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL)
Date: Fri, 01 Apr 2011 22:55:54 +0400 [thread overview]
Message-ID: <4D961FBA.8090107@ru.mvista.com> (raw)
In-Reply-To: <712525e420e78daeb3f43bf1ebc53e23@mail.gmail.com>
Hello.
Tirumala Marri wrote:
>>> +void dwc_otg_core_init(struct core_if *core_if)
>>> +{
>>> + u32 i;
>>> + ulong global_reg = core_if->core_global_regs;
>>> + struct device_if *dev_if = core_if->dev_if;
>>> + u32 ahbcfg = 0;
>>> + u32 i2cctl = 0;
>>> + u32 gusbcfg;
>> Tabify the declarations ;
> [Marri] When I checked again in my source, I do see the tabs added before
> declarations.
He means that tabs should be between the variable's type and name, but
there's no such requirement actually.
WBR, Sergei
next prev parent reply other threads:[~2011-04-01 18:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 18:27 [PATCH v10 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL) tmarri
2011-03-29 10:51 ` Keshava Munegowda
2011-04-01 17:35 ` Tirumala Marri
2011-04-01 18:55 ` Sergei Shtylyov [this message]
2011-04-05 7:08 ` Keshava Munegowda
2011-04-05 8:12 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D961FBA.8090107@ru.mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=fchen@apm$(echo .)com \
--cc=greg@kroah$(echo .)com \
--cc=keshava_mgowda@ti$(echo .)com \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mmiesfeld@apm$(echo .)com \
--cc=tmarri@apm$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox