From: Paul Gortmaker <paul.gortmaker@windriver•com>
To: Michael Guntsche <mike@it-loops•com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs•org>
Subject: Re: Powerpc compile error with 2.6.39-rc3 and non-SMP configs
Date: Wed, 13 Apr 2011 11:45:53 -0400 [thread overview]
Message-ID: <4DA5C531.1070508@windriver.com> (raw)
In-Reply-To: <20110413101737.GA25514@gibson.comsick.at>
On 11-04-13 06:17 AM, Michael Guntsche wrote:
> Hi,
>
> Commit b987812b3fc "powerpc/kexec: Fix mismatched ifdefs for PPC64/SMP."
> breaks compilation on non SMP powerpc machines.
Ah crap. I compile tested on SMP, so didn't see that.
> I wonder if this commit is really neccessary in the first place. The
> function definition itself is already between an
Your analysis is right, but I think getting rid of the #ifdefs is
still the right approach where possible. I'll send a fix shortly.
Thanks for the report.
P.
>
> #ifdef CONFIG_SMP (line 56)
> #endif
>
> block so only exists if SMP=y and PPC_STD_MMU_64=y.
> Furthermore the stub in your patch is only created if SMP=y and
> PPC_STD_MMU_64=n which breaks non-SMP configs.
>
> Kind regards,
> Michael Guntsche
prev parent reply other threads:[~2011-04-13 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 10:17 Powerpc compile error with 2.6.39-rc3 and non-SMP configs Michael Guntsche
2011-04-13 15:45 ` Paul Gortmaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA5C531.1070508@windriver.com \
--to=paul.gortmaker@windriver$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mike@it-loops$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox