From: Alexander Graf <agraf@suse•de>
To: Kumar Gala <galak@kernel•crashing.org>
Cc: Scott Wood <scottwood@freescale•com>,
linuxppc-dev@lists•ozlabs.org, kvm-ppc@vger•kernel.org
Subject: Re: [PATCH 01/13] powerpc/e500: Save SPEFCSR in flush_spe_to_thread()
Date: Thu, 19 May 2011 11:38:55 +0200 [thread overview]
Message-ID: <4DD4E52F.6040408@suse.de> (raw)
In-Reply-To: <DC207279-54AC-41CC-BF21-25181D16A6AB@kernel.crashing.org>
On 05/19/2011 08:04 AM, Kumar Gala wrote:
> On May 17, 2011, at 6:35 PM, Scott Wood wrote:
>
>> From: yu liu<yu.liu@freescale•com>
>>
>> giveup_spe() saves the SPE state which is protected by MSR[SPE].
>> However, modifying SPEFSCR does not trap when MSR[SPE]=0.
>> And since SPEFSCR is already saved/restored in _switch(),
>> not all the callers want to save SPEFSCR again.
>> Thus, saving SPEFSCR should not belong to giveup_spe().
>>
>> This patch moves SPEFSCR saving to flush_spe_to_thread(),
>> and cleans up the caller that needs to save SPEFSCR accordingly.
>>
>> Signed-off-by: Liu Yu<yu.liu@freescale•com>
>> Signed-off-by: Scott Wood<scottwood@freescale•com>
>> ---
>> This is a resending of http://patchwork.ozlabs.org/patch/88677/
>>
>> Kumar, please ack to go via kvm. This is holding up the rest of the SPE
>> patches, which in turn are holding up the MMU patches due to both
>> touching the MSR update code.
>>
>> arch/powerpc/kernel/head_fsl_booke.S | 2 --
>> arch/powerpc/kernel/process.c | 1 +
>> arch/powerpc/kernel/traps.c | 5 +----
>> 3 files changed, 2 insertions(+), 6 deletions(-)
> Acked-by: Kumar Gala<galak@kernel•crashing.org>
>
> [ Alex, let me know if you want this via my powerpc.git tree or your kvm tree ]
I'll take them :). Thanks!
Alex
prev parent reply other threads:[~2011-05-19 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 23:35 [PATCH 01/13] powerpc/e500: Save SPEFCSR in flush_spe_to_thread() Scott Wood
2011-05-17 23:36 ` [PATCH 02/13] powerpc/e500: SPE register saving: take arbitrary struct offset Scott Wood
2011-05-19 6:05 ` Kumar Gala
2011-05-19 6:04 ` [PATCH 01/13] powerpc/e500: Save SPEFCSR in flush_spe_to_thread() Kumar Gala
2011-05-19 9:38 ` Alexander Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD4E52F.6040408@suse.de \
--to=agraf@suse$(echo .)de \
--cc=galak@kernel$(echo .)crashing.org \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox