From: Meador Inge <meador_inge@mentor•com>
To: Scott Wood <scottwood@freescale•com>
Cc: openmcapi-dev@googlegroups•com,
Hollis Blanchard <hollis_blanchard@mentor•com>,
devicetree-discuss@lists•ozlabs.org,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v2 1/2] powerpc: document the FSL MPIC message register binding
Date: Tue, 31 May 2011 14:19:51 -0500 [thread overview]
Message-ID: <4DE53F57.2050402@mentor.com> (raw)
In-Reply-To: <20110526150643.3e01f9a6@schlenkerla.am.freescale.net>
On 05/26/2011 03:06 PM, Scott Wood wrote:
>> > + - interrupts: Specifies a list of interrupt source and level-sense pairs.
>> > + The type shall be <prop-encoded-array>. The length shall be equal to
>> > + the number of bits set in the 'msg-receive-mask' property value.
> Oh, just noticed -- mismatch between msg-receive-mask here...
>
>> > +
>> > +Optional properties:
>> > +
>> > + - mpic-msgr-receive-mask: Specifies what registers in the containing block
>> > + are allowed to receive interrupts. The value is a bit mask where a set
>> > + bit at bit 'n' indicates that message register 'n' can receive interrupts.
>> > + The type shall be <prop-encoded-array>. If not present, then all of
>> > + the message registers in the block are available.
> ...and mpic-msgr-receive-mask here.
>
> Might want to just say "equal to the number of registers that are
> available for receiving interrupts", to more clearly apply to the case where
> mpic-msgr-receive-mask is missing.
>
Thanks; fixed.
--
Meador Inge
CodeSourcery / Mentor Embedded
http://www.mentor.com/embedded-software
next prev parent reply other threads:[~2011-05-31 19:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 16:36 [PATCH v2 0/2] powerpc: define and implement MPIC message register support Meador Inge
2011-05-20 16:36 ` [PATCH v2 1/2] powerpc: document the FSL MPIC message register binding Meador Inge
2011-05-26 20:03 ` Scott Wood
2011-05-26 20:06 ` Scott Wood
2011-05-31 19:19 ` Meador Inge [this message]
2011-05-20 16:36 ` [PATCH v2 2/2] powerpc: add support for MPIC message register API Meador Inge
[not found] ` <BANLkTikvDEG4DSvVMtxa8=i=NV=o=DQLXA@mail.gmail.com>
2011-05-26 14:21 ` [PATCH v2 0/2] powerpc: define and implement MPIC message register support Meador Inge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE53F57.2050402@mentor.com \
--to=meador_inge@mentor$(echo .)com \
--cc=devicetree-discuss@lists$(echo .)ozlabs.org \
--cc=hollis_blanchard@mentor$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=openmcapi-dev@googlegroups$(echo .)com \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox