From: "H. Peter Anvin" <hpa@zytor•com>
To: Eric Paris <eparis@redhat•com>
Cc: linux-mips@linux-mips•org, linux-ia64@vger•kernel.org,
linux-sh@vger•kernel.org, heiko.carstens@de•ibm.com,
oleg@redhat•com, paulus@samba•org, sparclinux@vger•kernel.org,
linux-s390@vger•kernel.org, richard@nod•at, x86@kernel•org,
mingo@redhat•com, fenghua.yu@intel•com,
user-mode-linux-devel@lists•sourceforge.net,
microblaze-uclinux@itee•uq.edu.au, jdike@addtoit•com,
viro@zeniv•linux.org.uk, tglx@linutronix•de, monstr@monstr•eu,
tony.luck@intel•com, linux-kernel@vger•kernel.org,
ralf@linux-mips•org, lethal@linux-sh•org, schwidefsky@de•ibm.com,
linux390@de•ibm.com, akpm@linux-foundation•org,
linuxppc-dev@lists•ozlabs.org, davem@davemloft•net
Subject: Re: [PATCH] Audit: push audit success and retcode into arch ptrace.h
Date: Thu, 02 Jun 2011 14:18:34 -0700 [thread overview]
Message-ID: <4DE7FE2A.10107@zytor.com> (raw)
In-Reply-To: <20110602210458.23613.24076.stgit@paris.rdu.redhat.com>
On 06/02/2011 02:04 PM, Eric Paris wrote:
> The audit system previously expected arches calling to audit_syscall_exit to
> supply as arguments if the syscall was a success and what the return code was.
> Audit also provides a helper AUDITSC_RESULT which was supposed to simplify by
> converting from negative retcodes to an audit internal magic value stating
> success or failure. This helper was wrong and could indicate that a valid
> pointer returned to userspace was a failed syscall. The fix is to fix the
> layering foolishness. We now pass audit_syscall_exit a struct pt_reg and it
> in turns calls back into arch code to collect the return value and to
> determine if the syscall was a success or failure.
>
> In arch/sh/kernel/ptrace_64.c I see that we were using regs[9] in the old
> audit code. But the ptrace_64.h code was previously using regs[3] for the
> regs_return_value(). I have no idea which one is correct, but this patch now
> uses regs[3].
>
> Signed-off-by: Eric Paris <eparis@redhat•com>
For the x86 portions:
Acked-by: H. Peter Anvin <hpa@zytor•com>
-hpa
next prev parent reply other threads:[~2011-06-02 22:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 21:04 [PATCH] Audit: push audit success and retcode into arch ptrace.h Eric Paris
2011-06-02 21:18 ` H. Peter Anvin [this message]
2011-06-02 22:32 ` Richard Weinberger
2011-06-02 23:00 ` Tony Luck
2011-06-02 23:03 ` Richard Weinberger
2011-06-02 23:07 ` Eric Paris
2011-06-02 23:06 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE7FE2A.10107@zytor.com \
--to=hpa@zytor$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=eparis@redhat$(echo .)com \
--cc=fenghua.yu@intel$(echo .)com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=jdike@addtoit$(echo .)com \
--cc=lethal@linux-sh$(echo .)org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux390@de$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=microblaze-uclinux@itee$(echo .)uq.edu.au \
--cc=mingo@redhat$(echo .)com \
--cc=monstr@monstr$(echo .)eu \
--cc=oleg@redhat$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=ralf@linux-mips$(echo .)org \
--cc=richard@nod$(echo .)at \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=user-mode-linux-devel@lists$(echo .)sourceforge.net \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox