From: Chris Metcalf <cmetcalf@tilera•com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>
Cc: Arnd Bergmann <arnd@arndb•de>,
kumar.gala@freescale•com, linux-kernel@vger•kernel.org,
akpm@kernel•org, Deepak Saxena <dsaxena@linaro•org>,
linux-console@vger•kernel.org, greg@kroah•com,
linuxppc-dev@lists•ozlabs.org, Timur Tabi <timur@freescale•com>
Subject: Re: [PATCH 7/7] [v2] drivers/misc: introduce Freescale hypervisor management driver
Date: Mon, 6 Jun 2011 19:04:40 -0400 [thread overview]
Message-ID: <4DED5D08.3070704@tilera.com> (raw)
In-Reply-To: <20110606212356.GA20112@dumpdata.com>
For context, the most recent patch for the tile driver in question is here:
https://patchwork.kernel.org/patch/843892/
On 6/6/2011 5:23 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, Jun 06, 2011 at 05:01:36PM -0400, Chris Metcalf wrote:
>> On 6/6/2011 12:24 PM, Arnd Bergmann wrote:
>>> On Monday 06 June 2011, Timur Tabi wrote:.
>>>> And what about my concern that my driver will be the only one in drivers/virt?
>>> I have no doubt that more of these will come. Chris Metcalf is currently
>>> looking for a home for his tilera hypervisor drivers, and we have the
>>> microsoft hyperv drivers in drivers/staging, so they will hopefully
>>> move to a proper place later. We also have similar drivers in other
>>> places, e.g. drivers/ps3/ps3-sys-manager.c, drivers/s390/char/vmcp.c
>>> or parts of drivers/xen.
>> It might help if someone (Arnd?) wanted to propose a statement of what
>> drivers/virt was really for. If it's for any Linux driver that upcalls to
> Was for? I am not seeing it in v3.0-rc2?
Sorry, maybe a questionable idiom, but please read past tense in the quoted
text as meaning present tense :-)
>> a hypervisor for any reason, then the Tilera paravirtualized drivers fit in
>> well. If it's intended more for drivers that guests running under a
>> hypervisor can use to talk to the hypervisor itself (e.g. managing
> I believe that the code that deals with specific subsystem (so block API
> for example) would reside in subsystem directory (so drivers/block would have
> your virtualization block driver). This allows the maintainer of block
> to make sure your driver is OK.
Sure, makes sense. The new push (as I understand it) is to group primarily
by function, not by bus or architecture.
>> notifications that a hypervisor delivers to a guest to cause it to shut
>> down or take other actions), then it doesn't seem like the Tilera
> That looks to be arch/<x>/tilera/virt/ candidate?
Arnd, among others, has suggested that all drivers live in "drivers"
somewhere, so "arch/tile" may not be the best place. (To be fair, I
originally had this driver in arch/tile/drivers/, so your idea is certainly
reasonable!)
>> paravirtualized device drivers belong there, since they're just using the
>> Tilera hypervisor synchronously to do I/O or get/set device and driver state.
> Well, I/O sounds like block API or network API. But then you are also
> doing management ioctl - which implies "drivers". "drivers/tilera" does not
> work?
There is certainly precedent for drivers that don't fit cleanly into an
existing category to go in drivers/<arch>, e.g. drivers/s390,
drivers/parisc, etc. There is also drivers/platform/x86, though that seems
to be for the bus "platform drivers" rather than just a random character
driver like the one in question.
I don't have a particular opinion here; I'm just hoping to develop enough
consensus that I can ask Linus to pull the driver without generating
controversy :-)
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
next prev parent reply other threads:[~2011-06-06 23:04 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 18:35 [PATCH 7/7] [v2] drivers/misc: introduce Freescale hypervisor management driver Timur Tabi
2011-06-01 19:46 ` Alan Cox
2011-06-01 20:24 ` Timur Tabi
2011-06-01 20:34 ` Alan Cox
2011-06-01 20:54 ` Scott Wood
2011-06-01 21:45 ` Alan Cox
2011-06-01 21:40 ` Arnd Bergmann
2011-06-01 22:24 ` Scott Wood
2011-06-03 15:28 ` Arnd Bergmann
2011-06-03 16:22 ` Scott Wood
2011-06-06 15:53 ` Arnd Bergmann
2011-06-06 18:15 ` Scott Wood
2011-06-06 19:48 ` Arnd Bergmann
2011-06-02 21:28 ` Timur Tabi
2011-06-03 15:24 ` Arnd Bergmann
2011-06-03 15:28 ` Timur Tabi
2011-06-06 15:42 ` Arnd Bergmann
2011-06-06 15:48 ` Timur Tabi
2011-06-06 16:03 ` Arnd Bergmann
2011-06-06 16:09 ` Timur Tabi
2011-06-06 16:24 ` Arnd Bergmann
2011-06-06 16:27 ` Timur Tabi
2011-06-06 21:01 ` Chris Metcalf
2011-06-06 21:23 ` Konrad Rzeszutek Wilk
2011-06-06 23:04 ` Chris Metcalf [this message]
2011-06-07 7:08 ` Arnd Bergmann
2011-06-07 16:49 ` Chris Metcalf
2011-06-07 19:16 ` Arnd Bergmann
2011-06-07 19:20 ` Timur Tabi
2011-06-07 19:34 ` Arnd Bergmann
2011-06-03 14:44 ` Timur Tabi
2011-06-03 15:17 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DED5D08.3070704@tilera.com \
--to=cmetcalf@tilera$(echo .)com \
--cc=akpm@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=dsaxena@linaro$(echo .)org \
--cc=greg@kroah$(echo .)com \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=kumar.gala@freescale$(echo .)com \
--cc=linux-console@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox