From: Randy Dunlap <randy.dunlap@oracle•com>
To: Timur Tabi <timur@freescale•com>
Cc: arnd@arndb•de, konrad.wilk@oracle•com, kumar.gala@freescale•com,
linux-kernel@vger•kernel.org, cmetcalf@tilera•com,
akpm@kernel•org, dsaxena@linaro•org,
linux-console@vger•kernel.org, greg@kroah•com,
virtualization@lists•linux-foundation.org,
linuxppc-dev@lists•ozlabs.org, alan@lxorguk•ukuu.org.uk
Subject: Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver
Date: Thu, 09 Jun 2011 12:48:58 -0700 [thread overview]
Message-ID: <4DF123AA.6070402@oracle.com> (raw)
In-Reply-To: <4DF12345.1040409@freescale.com>
On 06/09/11 12:47, Timur Tabi wrote:
> Randy Dunlap wrote:
>>>> +enum fsl_hv_ioctl_cmd {
>>>> + FSL_HV_IOCTL_PARTITION_RESTART = _IOWR(0, 1, struct fsl_hv_ioctl_restart),
>>>> + FSL_HV_IOCTL_PARTITION_GET_STATUS = _IOWR(0, 2, struct fsl_hv_ioctl_status),
>>>> + FSL_HV_IOCTL_PARTITION_START = _IOWR(0, 3, struct fsl_hv_ioctl_start),
>>>> + FSL_HV_IOCTL_PARTITION_STOP = _IOWR(0, 4, struct fsl_hv_ioctl_stop),
>>>> + FSL_HV_IOCTL_MEMCPY = _IOWR(0, 5, struct fsl_hv_ioctl_memcpy),
>>>> + FSL_HV_IOCTL_DOORBELL = _IOWR(0, 6, struct fsl_hv_ioctl_doorbell),
>>>> + FSL_HV_IOCTL_GETPROP = _IOWR(0, 7, struct fsl_hv_ioctl_prop),
>>>> + FSL_HV_IOCTL_SETPROP = _IOWR(0, 8, struct fsl_hv_ioctl_prop),
>>>> +};
>
>> Missing an entry in Documentation/ioctl/ioctl-number.txt for 0 (with conflict!).
>
> If I change it from 0, I'm going to break binary compatibility with our apps. I
> agree that maybe I shouldn't have picked 0, but considering how many conflicts
> there already are, I wonder what the point is. Even if I pick a number that is
> currently not listed in the chart, that doesn't mean that it's actually not
> being used, or that it won't conflict in the future.
Yes, I understood that.
> So is it okay to stick with 0, or do I need to pick a new number?
I wasn't suggesting that you change the 0, just note that it has conflicts,
like other ioctls do.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-06-09 19:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 19:13 [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver Timur Tabi
2011-06-09 19:40 ` Randy Dunlap
2011-06-09 19:47 ` Timur Tabi
2011-06-09 19:48 ` Randy Dunlap [this message]
2011-06-09 20:25 ` Arnd Bergmann
2011-06-09 20:13 ` Arnd Bergmann
2011-06-09 20:18 ` Timur Tabi
2011-06-09 20:31 ` Greg KH
2011-06-09 20:40 ` Timur Tabi
2011-06-09 20:33 ` Arnd Bergmann
2011-06-10 10:45 ` Mark Brown
2011-06-10 8:32 ` [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisormanagement driver David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF123AA.6070402@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=akpm@kernel$(echo .)org \
--cc=alan@lxorguk$(echo .)ukuu.org.uk \
--cc=arnd@arndb$(echo .)de \
--cc=cmetcalf@tilera$(echo .)com \
--cc=dsaxena@linaro$(echo .)org \
--cc=greg@kroah$(echo .)com \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=kumar.gala@freescale$(echo .)com \
--cc=linux-console@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=timur@freescale$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox