From: Wolfgang Grandegger <wg@grandegger•com>
To: Robin Holt <holt@sgi•com>
Cc: socketcan-core@lists•berlios.de, netdev@vger•kernel.org,
U Bhaskar-B22300 <B22300@freescale•com>,
Scott Wood <scottwood@freescale•com>,
PPC list <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH v11 6/6] powerpc: Add flexcan device support for p1010rdb.
Date: Thu, 11 Aug 2011 18:35:08 +0200 [thread overview]
Message-ID: <4E4404BC.7060502@grandegger.com> (raw)
In-Reply-To: <1313078831-2511-7-git-send-email-holt@sgi.com>
On 08/11/2011 06:07 PM, Robin Holt wrote:
> Allow the p1010 processor to select the flexcan network driver.
>
> Signed-off-by: Robin Holt <holt@sgi•com>
> Acked-by: Marc Kleine-Budde <mkl@pengutronix•de>,
> Acked-by: Wolfgang Grandegger <wg@grandegger•com>,
> Cc: U Bhaskar-B22300 <B22300@freescale•com>
> Cc: socketcan-core@lists•berlios.de,
> Cc: netdev@vger•kernel.org,
> Cc: PPC list <linuxppc-dev@lists•ozlabs.org>
> Cc: Kumar Gala <galak@kernel•crashing.org>
> ---
> arch/powerpc/boot/dts/p1010rdb.dts | 8 ++++++++
> arch/powerpc/platforms/85xx/Kconfig | 2 ++
> 2 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/p1010rdb.dts b/arch/powerpc/boot/dts/p1010rdb.dts
> index d6c669c..df89b60 100644
> --- a/arch/powerpc/boot/dts/p1010rdb.dts
> +++ b/arch/powerpc/boot/dts/p1010rdb.dts
> @@ -171,6 +171,14 @@
> };
> };
>
> + can@1c000 {
> + clock-frequency = <0x0bebc1fc>;
> + };
clock-frequency = <200000000>; // filled in by boot-loader
Is better readable and makes clear that the value is filled in by the
boot loader. Usually we specify "<0>" in that case but it will *not*
work with your board because U-Boot fills into the property "clock_freq"
the CCB-frequency, which is twice as much. This needs to be fixed.
> + can1: can@1d000 {
What is the "can1:" good for?
> + clock-frequency = <0x0bebc1fc>;
See above.
Wolfgang.
> usb@22000 {
> phy_type = "utmi";
> };
> diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig
> index 498534c..c4304ae 100644
> --- a/arch/powerpc/platforms/85xx/Kconfig
> +++ b/arch/powerpc/platforms/85xx/Kconfig
> @@ -70,6 +70,8 @@ config MPC85xx_RDB
> config P1010_RDB
> bool "Freescale P1010RDB"
> select DEFAULT_UIMAGE
> + select HAVE_CAN_FLEXCAN if NET && CAN
> + select PPC_CLOCK if CAN_FLEXCAN
> help
> This option enables support for the MPC85xx RDB (P1010 RDB) board
>
next prev parent reply other threads:[~2011-08-11 16:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 16:07 [PATCH v12 0/6] flexcan/powerpc: Add support for powerpc flexcan (freescale p1010) Robin Holt
2011-08-11 16:07 ` [PATCH v11 1/6] flexcan: Remove #include <mach/clock.h> Robin Holt
2011-08-11 16:07 ` [PATCH v11 2/6] flexcan: Abstract off read/write for big/little endian Robin Holt
2011-08-11 16:07 ` [PATCH v11 3/6] flexcan: Fix up fsl-flexcan device tree binding Robin Holt
2011-08-11 16:53 ` Grant Likely
2011-08-12 8:28 ` Robin Holt
2011-08-11 16:07 ` [PATCH v11 4/6] flexcan: Add of_match to platform_device definition Robin Holt
2011-08-11 16:07 ` [PATCH v11 5/6] flexcan: Prefer device tree clock frequency if available Robin Holt
2011-08-11 16:18 ` Marc Kleine-Budde
2011-08-11 17:40 ` Kumar Gala
2011-08-11 16:35 ` Wolfgang Grandegger
2011-08-11 16:07 ` [PATCH v11 6/6] powerpc: Add flexcan device support for p1010rdb Robin Holt
2011-08-11 16:35 ` Wolfgang Grandegger [this message]
2011-08-11 16:48 ` Robin Holt
2011-08-11 17:41 ` Kumar Gala
2011-08-11 18:12 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4404BC.7060502@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=B22300@freescale$(echo .)com \
--cc=holt@sgi$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=scottwood@freescale$(echo .)com \
--cc=socketcan-core@lists$(echo .)berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox