From: Wolfgang Grandegger <wg@grandegger•com>
To: Robin Holt <holt@sgi•com>
Cc: socketcan-core@lists•berlios.de, netdev@vger•kernel.org,
devicetree-discuss@lists•ozlabs.org,
U Bhaskar-B22300 <B22300@freescale•com>,
Scott Wood <scottwood@freescale•com>,
PPC list <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH v11 5/6] flexcan: Prefer device tree clock frequency if available.
Date: Thu, 11 Aug 2011 18:35:50 +0200 [thread overview]
Message-ID: <4E4404E6.5060302@grandegger.com> (raw)
In-Reply-To: <1313078831-2511-6-git-send-email-holt@sgi.com>
On 08/11/2011 06:07 PM, Robin Holt wrote:
> If our CAN device's device tree node has a clock-frequency property,
> then use that value for the can devices clock frequency. If not, fall
> back to asking the platform/mach code for the clock frequency associated
> with the flexcan device.
>
> Signed-off-by: Robin Holt <holt@sgi•com>
> To: Kumar Gala <galak@kernel•crashing.org>
> To: Wolfgang Grandegger <wg@grandegger•com>,
> To: Marc Kleine-Budde <mkl@pengutronix•de>,
> To: U Bhaskar-B22300 <B22300@freescale•com>
> To: Scott Wood <scottwood@freescale•com>
> To: Grant Likely <grant.likely@secretlab•ca>
> Cc: socketcan-core@lists•berlios.de,
> Cc: netdev@vger•kernel.org,
> Cc: PPC list <linuxppc-dev@lists•ozlabs.org>
> Cc: devicetree-discuss@lists•ozlabs.org
> ---
> .../devicetree/bindings/net/can/fsl-flexcan.txt | 2 +
> drivers/net/can/flexcan.c | 33 +++++++++++++++-----
> 2 files changed, 27 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> index c78dcbb..a4382c7 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> @@ -11,6 +11,7 @@ Required properties:
>
> - reg : Offset and length of the register set for this device
> - interrupts : Interrupt tuple for this device
> +- clock-frequency : The oscillator frequency driving the flexcan device
>
> Example:
>
> @@ -19,4 +20,5 @@ Example:
> reg = <0x1c000 0x1000>;
> interrupts = <48 0x2>;
> interrupt-parent = <&mpic>;
> + clock-frequency = <0x0bebc1fc>;
clock-frequency = <200000000>; // filled in by bootloader
Is better readable. You should also add the comment.
Wolfgang.
next prev parent reply other threads:[~2011-08-11 16:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 16:07 [PATCH v12 0/6] flexcan/powerpc: Add support for powerpc flexcan (freescale p1010) Robin Holt
2011-08-11 16:07 ` [PATCH v11 1/6] flexcan: Remove #include <mach/clock.h> Robin Holt
2011-08-11 16:07 ` [PATCH v11 2/6] flexcan: Abstract off read/write for big/little endian Robin Holt
2011-08-11 16:07 ` [PATCH v11 3/6] flexcan: Fix up fsl-flexcan device tree binding Robin Holt
2011-08-11 16:53 ` Grant Likely
2011-08-12 8:28 ` Robin Holt
2011-08-11 16:07 ` [PATCH v11 4/6] flexcan: Add of_match to platform_device definition Robin Holt
2011-08-11 16:07 ` [PATCH v11 5/6] flexcan: Prefer device tree clock frequency if available Robin Holt
2011-08-11 16:18 ` Marc Kleine-Budde
2011-08-11 17:40 ` Kumar Gala
2011-08-11 16:35 ` Wolfgang Grandegger [this message]
2011-08-11 16:07 ` [PATCH v11 6/6] powerpc: Add flexcan device support for p1010rdb Robin Holt
2011-08-11 16:35 ` Wolfgang Grandegger
2011-08-11 16:48 ` Robin Holt
2011-08-11 17:41 ` Kumar Gala
2011-08-11 18:12 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4404E6.5060302@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=B22300@freescale$(echo .)com \
--cc=devicetree-discuss@lists$(echo .)ozlabs.org \
--cc=holt@sgi$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=scottwood@freescale$(echo .)com \
--cc=socketcan-core@lists$(echo .)berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox