Subject: Re: [PATCH v11 5/6] flexcan: Prefer device tree clock frequency if available.

From: Wolfgang Grandegger <[email-masked]>
Date: Thu, 11 Aug 2011 18:35:50 +0200

On 08/11/2011 06:07 PM, Robin Holt wrote:
> If our CAN device's device tree node has a clock-frequency property,
> then use that value for the can devices clock frequency.  If not, fall
> back to asking the platform/mach code for the clock frequency associated
> with the flexcan device.
> 
> Signed-off-by: Robin Holt <[email-masked]>
> To: Kumar Gala <[email-masked]>
> To: Wolfgang Grandegger <[email-masked]>,
> To: Marc Kleine-Budde <[email-masked]>,
> To: U Bhaskar-B22300 <[email-masked]>
> To: Scott Wood <[email-masked]>
> To: Grant Likely <[email-masked]>
> Cc: [email-masked],
> Cc: [email-masked],
> Cc: PPC list <[email-masked]>
> Cc: [email-masked]
> ---
>  .../devicetree/bindings/net/can/fsl-flexcan.txt    |    2 +
>  drivers/net/can/flexcan.c                          |   33 +++++++++++++++-----
>  2 files changed, 27 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> index c78dcbb..a4382c7 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> @@ -11,6 +11,7 @@ Required properties:
>  
>  - reg : Offset and length of the register set for this device
>  - interrupts : Interrupt tuple for this device
> +- clock-frequency : The oscillator frequency driving the flexcan device
>  
>  Example:
>  
> @@ -19,4 +20,5 @@ Example:
>            reg = <0x1c000 0x1000>;
>            interrupts = <48 0x2>;
>            interrupt-parent = <&mpic>;
> +          clock-frequency = <0x0bebc1fc>;

             clock-frequency = <200000000>; // filled in by bootloader

Is better readable. You should also add the comment.
	
Wolfgang.