From: Sergei Shtylyov <sshtylyov@mvista•com>
To: Pratyush Anand <pratyush.anand@st•com>
Cc: viresh.kumar@st•com, vipulkumar.samar@st•com,
bhupesh.sharma@st•com, tmarri@apm•com, linux-usb@vger•kernel.org,
vipin.kumar@st•com, shiraz.hashim@st•com, Amit.VIRDI@st•com,
rajeev-dlh.kumar@st•com, mmiesfeld@apm•com, deepak.sikri@st•com,
linuxppc-dev@lists•ozlabs.org, fchen@apm•com
Subject: Re: [PATCH 11/14] dwc/otg: Driver enable gadget support
Date: Tue, 30 Aug 2011 17:01:32 +0400 [thread overview]
Message-ID: <4E5CDF2C.8030400@ru.mvista.com> (raw)
In-Reply-To: <d12fef0c09645ba1cd56dd011b5090cc8bde4b4b.1314704558.git.pratyush.anand@st.com>
Hello.
On 08/30/2011 03:57 PM, Pratyush Anand wrote:
> From: Tirumala Marri<tmarri@apm•com>
> Enable gadget support
> Signed-off-by: Tirumala R Marri<tmarri@apm•com>
> Signed-off-by: Fushen Chen<fchen@apm•com>
> Signed-off-by: Mark Miesfeld<mmiesfeld@apm•com>
> Signed-off-by: Pratyush Anand<pratyush.anand@st•com>
> ---
> drivers/usb/gadget/gadget_chips.h | 18 +++++++++++++++++-
> 1 files changed, 17 insertions(+), 1 deletions(-)
> diff --git a/drivers/usb/gadget/gadget_chips.h b/drivers/usb/gadget/gadget_chips.h
> index 0978103..66b8018 100644
> --- a/drivers/usb/gadget/gadget_chips.h
> +++ b/drivers/usb/gadget/gadget_chips.h
> @@ -148,6 +148,19 @@
> #define gadget_is_s3c_hsotg(g) 0
> #endif
>
> +#if defined(CONFIG_DWC_OTG_MODE) || defined(CONFIG_DWC_DEVICE_ONLY)
> +#define gadget_is_dwc_otg_pcd(g) (!strcmp("dwc_otg_pcd", (g)->name))
> +#else
> +#define gadget_is_dwc_otg_pcd(g) 0
> +#endif
> +
> +#ifdef CONFIG_USB_GADGET_CI13XXX_MSM
> +#define gadget_is_ci13xxx_msm(g) (!strcmp("ci13xxx_msm", (g)->name))
> +#else
> +#define gadget_is_ci13xxx_msm(g) 0
> +#endif
> +
> +
Too many newlines.
>
> /**
> * usb_gadget_controller_number - support bcdDevice id convention
> @@ -208,10 +221,13 @@ static inline int usb_gadget_controller_number(struct usb_gadget *gadget)
> return 0x26;
> else if (gadget_is_designware(gadget))
> return 0x27;
> + else if (gadget_is_ci13xxx_msm(gadget))
> + return 0x28;
> + else if (gadget_is_dwc_otg_pcd(gadget))
> + return 0x29;
Hm, why are you adding 2 gadgets?
> return -ENOENT;
> }
>
> -
Unrelated white space change.
> /**
> * gadget_supports_altsettings - return true if altsettings work
> * @gadget: the gadget in question
WBR, Sergei
next prev parent reply other threads:[~2011-08-30 13:03 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 11:57 [PATCH 00/14] Modifications for DWC OTG since v13 Pratyush Anand
2011-08-30 11:57 ` [PATCH 01/14] dwc/otg: Add Register definitions Pratyush Anand
2011-08-31 22:35 ` Greg KH
2011-09-02 11:31 ` Pratyush Anand
2011-08-30 11:57 ` [PATCH 02/14] dwc/otg: Structure declaration for shared data Pratyush Anand
2011-08-30 15:29 ` Tirumala Marri
2011-08-30 15:43 ` Pratyush Anand
2011-08-31 17:17 ` Tirumala Marri
2011-09-02 11:42 ` Pratyush Anand
2011-09-02 12:30 ` Alexander Gordeev
2011-09-02 16:40 ` Tirumala Marri
2011-09-02 16:37 ` Tirumala Marri
2011-08-31 22:36 ` Greg KH
2011-09-01 0:18 ` Josh Boyer
2011-09-01 1:37 ` Greg KH
2011-08-31 22:36 ` Greg KH
2011-09-02 11:49 ` Pratyush Anand
2011-09-02 13:57 ` Greg KH
2011-08-30 11:57 ` [PATCH 03/14] dwc/otg: Add driver framework Pratyush Anand
2011-08-31 7:19 ` Sebastian Andrzej Siewior
2011-09-02 11:17 ` Pratyush Anand
2011-09-02 11:32 ` Sebastian Andrzej Siewior
2011-09-02 11:55 ` Pratyush Anand
2011-08-30 11:57 ` [PATCH 04/14] dwc/otg: Add Core Interface Layer (CIL) Pratyush Anand
2011-08-30 11:57 ` [PATCH 05/14] dwc/otg: Add HCD function Pratyush Anand
2011-08-30 11:57 ` [PATCH 06/14] dwc/otg: Add HCD interrupt function Pratyush Anand
2011-08-30 11:57 ` [PATCH 07/14] dwc/otg: Add HCD queue function Pratyush Anand
2011-08-30 11:57 ` [PATCH 08/14] dwc/otg: Add PCD function Pratyush Anand
2011-08-31 7:44 ` Sebastian Andrzej Siewior
2011-09-02 11:26 ` Pratyush Anand
2011-08-30 11:57 ` [PATCH 09/14] dwc/otg: Add PCD interrupt function Pratyush Anand
2011-08-30 11:57 ` [PATCH 10/14] dwc/otg: Add driver kernel configuration and Makefile Pratyush Anand
2011-08-30 11:57 ` [PATCH 11/14] dwc/otg: Driver enable gadget support Pratyush Anand
2011-08-30 13:01 ` Sergei Shtylyov [this message]
2011-08-30 15:40 ` Pratyush Anand
2011-08-30 11:57 ` [PATCH 12/14] include/linux/usb/gadget.h : include <linux/device.h> for successful compilation Pratyush Anand
2011-08-30 12:57 ` Sergei Shtylyov
2011-08-30 11:58 ` [PATCH 13/14] usb/gadget/kconfig: added dwc otg as an option for peripheral controller Pratyush Anand
2011-08-30 11:58 ` [PATCH 14/14] arm/include/asm/io.h : added macros to read/write big/little endian register Pratyush Anand
2011-08-31 7:35 ` Sebastian Andrzej Siewior
2011-09-02 10:43 ` Pratyush Anand
2011-09-02 11:02 ` Benjamin Herrenschmidt
2011-09-02 11:01 ` Benjamin Herrenschmidt
2011-09-05 14:28 ` Sebastian Andrzej Siewior
2011-09-05 17:16 ` Benjamin Herrenschmidt
2011-08-30 15:27 ` [PATCH 00/14] Modifications for DWC OTG since v13 Tirumala Marri
2011-08-30 15:46 ` Pratyush Anand
2011-08-31 1:18 ` Kyungmin Park
2011-08-31 6:49 ` Alexander Gordeev
2011-08-31 7:03 ` Pratyush Anand
2011-08-31 20:33 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5CDF2C.8030400@ru.mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=Amit.VIRDI@st$(echo .)com \
--cc=bhupesh.sharma@st$(echo .)com \
--cc=deepak.sikri@st$(echo .)com \
--cc=fchen@apm$(echo .)com \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mmiesfeld@apm$(echo .)com \
--cc=pratyush.anand@st$(echo .)com \
--cc=rajeev-dlh.kumar@st$(echo .)com \
--cc=shiraz.hashim@st$(echo .)com \
--cc=tmarri@apm$(echo .)com \
--cc=vipin.kumar@st$(echo .)com \
--cc=vipulkumar.samar@st$(echo .)com \
--cc=viresh.kumar@st$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox