From: Scott Wood <scottwood@freescale•com>
To: Tabi Timur-B04825 <B04825@freescale•com>
Cc: Wood Scott-B07421 <B07421@freescale•com>,
"devicetree-discuss@lists•ozlabs.org"
<devicetree-discuss@lists•ozlabs.org>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH] powerpc/fsl_msi: Handle msi-available-ranges better
Date: Tue, 13 Sep 2011 13:33:06 -0500 [thread overview]
Message-ID: <4E6FA1E2.2060706@freescale.com> (raw)
In-Reply-To: <CAOZdJXVm1YL-T8i26O0BiB-uTkXUDnYQdacU8k52aG-K0pZ1Lg@mail.gmail.com>
On 09/07/2011 11:20 AM, Tabi Timur-B04825 wrote:
> The problem is that both offset and irq_index are being incremented in
> the loop, and cascade_data->index is set to the sum of the two.
>
> Perhaps you meant this:
>
> err = fsl_msi_setup_hwirq(msi, dev, offset, j);
That's not right either, it would retrieve the wrong IRQ from the
interrupts property if you have holes -- try with something like
{ 0 64, 128, 64 }. The desired behavior there is:
offset = 0 irq_index = 0
offset = 1 irq_index = 1
offset = 4 irq_index = 2
offset = 5 irq_index = 3
I think the right code (untested) might be:
err = fsl_msi_setup_hwirq(msi, dev, offset + j, irq_index);
and
cascade_data->index = offset;
-Scott
prev parent reply other threads:[~2011-09-13 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 20:25 [PATCH] powerpc/fsl_msi: Handle msi-available-ranges better Scott Wood
2011-03-15 17:58 ` Kumar Gala
2011-09-07 16:20 ` Tabi Timur-B04825
2011-09-13 18:33 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6FA1E2.2060706@freescale.com \
--to=scottwood@freescale$(echo .)com \
--cc=B04825@freescale$(echo .)com \
--cc=B07421@freescale$(echo .)com \
--cc=devicetree-discuss@lists$(echo .)ozlabs.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox