From: Scott Wood <scottwood@freescale•com>
To: Prabhakar Kushwaha <prabhakar@freescale•com>
Cc: linux-mtd@lists•infradead.org, linuxppc-dev@lists•ozlabs.org,
Poonam Aggrwal <poonam.aggrwal@freescale•com>
Subject: Re: [PATCH 2/2] mtd/nand: Fix IFC driver to support 2K NAND page
Date: Tue, 3 Jan 2012 13:49:51 -0600 [thread overview]
Message-ID: <4F035BDF.5070207@freescale.com> (raw)
In-Reply-To: <1325134779-3571-3-git-send-email-prabhakar@freescale.com>
On 12/28/2011 10:59 PM, Prabhakar Kushwaha wrote:
> 1) OOB area should be updated irrespective of NAND page size. Earlier it was
> updated only for 512byte NAND page.
>
> 2) During OOB update fbcr should be equal to OOB size.
>
> Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale•com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale•com>
> ---
> git://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git (branch next)
The IFC driver hasn't been merged into that tree that I can see.
> Tested on P1010RDB
>
> drivers/mtd/nand/fsl_ifc_nand.c | 20 ++++++++------------
> 1 files changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
> index 2df7206..2c02168 100644
> --- a/drivers/mtd/nand/fsl_ifc_nand.c
> +++ b/drivers/mtd/nand/fsl_ifc_nand.c
> @@ -439,20 +439,16 @@ static void fsl_ifc_cmdfunc(struct mtd_info *mtd, unsigned int command,
> out_be32(&ifc->ifc_nand.nand_fir1,
> (IFC_FIR_OP_CW1 << IFC_NAND_FIR1_OP5_SHIFT));
>
> - if (column >= mtd->writesize) {
> - /* OOB area --> READOOB */
> - column -= mtd->writesize;
> - nand_fcr0 |= NAND_CMD_READOOB <<
> - IFC_NAND_FCR0_CMD0_SHIFT;
> - ifc_nand_ctrl->oob = 1;
> - } else if (column < 256)
> + if (column < 256)
> /* First 256 bytes --> READ0 */
> nand_fcr0 |=
> NAND_CMD_READ0 << IFC_NAND_FCR0_CMD0_SHIFT;
> - else
> - /* Second 256 bytes --> READ1 */
> - nand_fcr0 |=
> - NAND_CMD_READ1 << IFC_NAND_FCR0_CMD0_SHIFT;
> + }
> +
> + if (column >= mtd->writesize) {
> + /* OOB area --> READOOB */
> + column -= mtd->writesize;
> + ifc_nand_ctrl->oob = 1;
> }
Where is NAND_CMD_READOOB going to be set in the small-page case?
The small-page code should read something like:
if (column >= mtd->writesize) {
nand_fcr0 |=
NAND_CMD_READOOB << IFC_NAND_FCR0_CMD0_SHIFT;
} else {
nand_fcr0 |=
NAND_CMD_READ0 << IFC_NAND_FCR0_CMD0_SHIFT;
}
It looks like we can get rid of ctrl->column, BTW.
-Scott
next prev parent reply other threads:[~2012-01-03 19:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-29 4:59 mtd/NAND:Fix issues with freescale IFC to support NAND 2K Prabhakar Kushwaha
2011-12-29 4:59 ` [PATCH 1/2] mtd/nand:Fix wrong address read in is_blank() Prabhakar Kushwaha
2012-01-03 20:24 ` Scott Wood
2012-01-04 4:35 ` Prabhakar
2011-12-29 4:59 ` [PATCH 2/2] mtd/nand: Fix IFC driver to support 2K NAND page Prabhakar Kushwaha
2012-01-03 19:49 ` Scott Wood [this message]
2012-01-04 4:58 ` Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F035BDF.5070207@freescale.com \
--to=scottwood@freescale$(echo .)com \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=poonam.aggrwal@freescale$(echo .)com \
--cc=prabhakar@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox