From: Scott Wood <scottwood@freescale•com>
To: Zhicheng Fan <B32736@freescale•com>
Cc: linuxppc-dev@lists•ozlabs.org, Zhicheng Fan <b32736@freeescale•com>
Subject: Re: [PATCH 1/2 v2] powerpc/dts: Add dts for p1020rdb-pc
Date: Tue, 31 Jan 2012 12:55:15 -0600 [thread overview]
Message-ID: <4F283913.3010001@freescale.com> (raw)
In-Reply-To: <1327993614-25915-1-git-send-email-B32736@freescale.com>
On 01/31/2012 01:06 AM, Zhicheng Fan wrote:
> +&lbc {
> + nor@0,0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "cfi-flash";
> + reg = <0x0 0x0 0x1000000>;
> + bank-width = <2>;
> + device-width = <1>;
> +
> + partition@0 {
> + /* This location must not be altered */
> + /* 256KB for Vitesse 7385 Switch firmware */
> + reg = <0x0 0x00040000>;
> + label = "NOR (RO) Vitesse-7385 Firmware";
> + read-only;
> + };
> +
> + partition@40000 {
> + /* 256KB for DTB Image */
> + reg = <0x00040000 0x00040000>;
> + label = "NOR (RO) DTB Image";
> + read-only;
> + };
> +
> + partition@80000 {
> + /* 3.5 MB for Linux Kernel Image */
> + reg = <0x00080000 0x00380000>;
> + label = "NOR (RO) Linux Kernel Image";
> + read-only;
> + };
> +
> + partition@400000 {
> + /* 11MB for JFFS2 based Root file System */
> + reg = <0x00400000 0x00b00000>;
> + label = "NOR (RW) JFFS2 Root File System";
> + };
> +
> + partition@f00000 {
> + /* This location must not be altered */
> + /* 512KB for u-boot Bootloader Image */
> + /* 512KB for u-boot Environment Variables */
> + reg = <0x00f00000 0x00100000>;
> + label = "NOR (RO) U-Boot Image";
> + read-only;
> + };
> + };
> +
> + nand@1,0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "fsl,p1020-fcm-nand",
> + "fsl,elbc-fcm-nand";
> + reg = <0x1 0x0 0x40000>;
> +
> + partition@0 {
> + /* This location must not be altered */
> + /* 1MB for u-boot Bootloader Image */
> + reg = <0x0 0x00100000>;
> + label = "NAND (RO) U-Boot Image";
> + read-only;
> + };
> +
> + partition@100000 {
> + /* 1MB for DTB Image */
> + reg = <0x00100000 0x00100000>;
> + label = "NAND (RO) DTB Image";
> + read-only;
> + };
> +
> + partition@200000 {
> + /* 4MB for Linux Kernel Image */
> + reg = <0x00200000 0x00400000>;
> + label = "NAND (RO) Linux Kernel Image";
> + read-only;
> + };
> +
> + partition@600000 {
> + /* 4MB for Compressed Root file System Image */
> + reg = <0x00600000 0x00400000>;
> + label = "NAND (RO) Compressed RFS Image";
> + read-only;
> + };
> +
> + partition@a00000 {
> + /* 7MB for JFFS2 based Root file System */
> + reg = <0x00a00000 0x00700000>;
> + label = "NAND (RW) JFFS2 Root File System";
> + };
> +
> + partition@1100000 {
> + /* 15MB for JFFS2 based Root file System */
> + reg = <0x01100000 0x00f00000>;
> + label = "NAND (RW) Writable User area";
> + };
> + };
Please remove (RO) and (RW) -- this duplicates information provided by
the read-only property.
Please only mark partitions read-only when they could brick the board if
overwritten. Things like the Linux kernel, RFS, and DTB should not be
read-only.
> +/include/ "p1020rdb-pc.dts"
> +
> +/ {
> + model = "fsl,P1020RDB-PC";
> + compatible = "fsl,P1020RDB-PC", "fsl,MPC85XXRDB-CAMP";
Eliminate fsl,MPC85XXRDB-CAMP. Specify pic-no-reset on the mpic node
instead.
-Scott
prev parent reply other threads:[~2012-01-31 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 7:06 [PATCH 1/2 v2] powerpc/dts: Add dts for p1020rdb-pc Zhicheng Fan
2012-01-31 7:06 ` [PATCH 2/2 v2] P1020RDB-PC: Add p1020rdb-pc platform support Zhicheng Fan
2012-01-31 18:55 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F283913.3010001@freescale.com \
--to=scottwood@freescale$(echo .)com \
--cc=B32736@freescale$(echo .)com \
--cc=b32736@freeescale$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox