Subject: Re: [linuxppc-release] [PATCH 2/2] powerpc/85xx: update SEC node in dts for MPC8572DS

From: Timur Tabi <[email-masked]>
Date: Wed, 8 Feb 2012 10:39:43 -0600

Jia Hongtao wrote:
> Add sec3.1 support
> 
> Signed-off-by: Jin Qing <[email-masked]>
> Signed-off-by: Zhao Chenhui <[email-masked]>
> Signed-off-by: Jia Hongtao <[email-masked]>
> Signed-off-by: Li Yang <[email-masked]>
> ---
>  arch/powerpc/boot/dts/fsl/mpc8572si-post.dtsi |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/fsl/mpc8572si-post.dtsi b/arch/powerpc/boot/dts/fsl/mpc8572si-post.dtsi
> index d44e25a..cdda34f 100644
> --- a/arch/powerpc/boot/dts/fsl/mpc8572si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/mpc8572si-post.dtsi
> @@ -184,7 +184,7 @@
>  /include/ "pq3-etsec1-1.dtsi"
>  /include/ "pq3-etsec1-2.dtsi"
>  /include/ "pq3-etsec1-3.dtsi"
> -/include/ "pq3-sec3.0-0.dtsi"
> +/include/ "pq3-sec3.1-0.dtsi"

This is not "adding SEC 3.1 support".  This patch is saying that the 8572
DTS was using the *wrong* SEC version.  If that's true, you need to
explain why it was wrong.

-- 
Timur Tabi
Linux kernel developer at Freescale