Subject: Re: [PATCH 33/37] KVM: PPC: bookehv: remove unused code

From: Scott Wood <[email-masked]>
Date: Fri, 24 Feb 2012 17:31:31 -0600

On 02/24/2012 08:26 AM, Alexander Graf wrote:
> There was some unused code in the exit code path that must have been
> a leftover from earlier iterations. While it did no hard, it's superfluous
> and thus should be removed.

s/hard/harm/ -- at that assumes exit timing wasn't enabled. :-)

> 
> Signed-off-by: Alexander Graf <[email-masked]>
> ---
>  arch/powerpc/kvm/bookehv_interrupts.S |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/kvm/bookehv_interrupts.S b/arch/powerpc/kvm/bookehv_interrupts.S
> index 021d087..b1c099b 100644
> --- a/arch/powerpc/kvm/bookehv_interrupts.S
> +++ b/arch/powerpc/kvm/bookehv_interrupts.S
> @@ -112,9 +112,6 @@
>  	 * appropriate for the exception type).
>  	 */
>  	cmpw	r6, r8
> -	.if	\flags & NEED_EMU
> -	lwz	r9, KVM_LPID(r9)
> -	.endif
>  	beq	1f
>  	mfmsr	r7
>  	.if	\srr0 != SPRN_MCSRR0 && \srr0 != SPRN_CSRR0

Can also remove "lwz	r9, VCPU_KVM(r4)".

-Scott