From: Nicolas Ferre <nicolas.ferre@atmel•com>
To: Russell King - ARM Linux <linux@arm•linux.org.uk>,
Vinod Koul <vinod.koul@intel•com>
Cc: Stephen Warren <swarren@nvidia•com>,
Linus Walleij <linus.walleij@stericsson•com>,
Srinidhi Kasagar <srinidhi.kasagar@stericsson•com>,
Barry Song <baohua.song@csr•com>,
Dan Williams <dan.j.williams@intel•com>,
linuxppc-dev@lists•ozlabs.org,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v2 0/9] DMA engine cookie handling cleanups
Date: Tue, 13 Mar 2012 12:45:56 +0100 [thread overview]
Message-ID: <4F5F3374.8000506@atmel.com> (raw)
In-Reply-To: <20120306223321.GD15201@n2100.arm.linux.org.uk>
On 03/06/2012 11:33 PM, Russell King - ARM Linux :
> [v2 - more or less same description. Including lakml in cc for the full
> set]
>
> This patch series cleans up the handling of cookies in DMA engine drivers.
> This is done by providing a set of inline library functions for common
> tasks:
>
> - moving the 'last completed cookie' into struct dma_chan - everyone
> has this in their driver private channel data structure
>
> - consolidate allocation of cookies to DMA descriptors
>
> - common way to update 'last completed cookie' value
>
> - standard way to implement tx_status callback and update the residue
>
> - consolidate initialization of cookies
>
> - update implementations differing from the majority of DMA engine drivers
> to behave the same as the majority implementation in respect of cookies
>
> What this means is that we get to the point where all DMA engine drivers
> will hand out cookie value '2' as the first, and incrementing cookie
> values up to INT_MAX, returning to cookie '1' as the next cookie.
>
> Think of this patch series as round 1... I am hoping over time that more
> code can be consolidated between the DMA engine drivers and end up with a
> consistent way to handle various common themes in DMA engine hardware
> (like physical channel<->peripheral request signal selection.)
>
> Overall, the diffstat looks like this:
>
> arch/arm/include/asm/hardware/iop_adma.h | 2 -
> drivers/dma/amba-pl08x.c | 38 ++++---------
> drivers/dma/at_hdmac.c | 48 ++++------------
> drivers/dma/at_hdmac_regs.h | 2 -
For at_hdmac Atmel DMA driver:
Tested-by: Nicolas Ferre <nicolas.ferre@atmel•com>
Thanks a lot Russell.
Best regards,
--
Nicolas Ferre
prev parent reply other threads:[~2012-03-13 11:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 22:33 [PATCH v2 0/9] DMA engine cookie handling cleanups Russell King - ARM Linux
2012-03-06 22:34 ` [PATCH 2/9] dmaengine: move last completed cookie into generic dma_chan structure Russell King - ARM Linux
2012-03-07 0:38 ` H Hartley Sweeten
2012-03-06 22:34 ` [PATCH 3/9] dmaengine: add private header file Russell King - ARM Linux
2012-03-07 0:47 ` H Hartley Sweeten
2012-03-06 22:34 ` [PATCH 4/9] dmaengine: consolidate assignment of DMA cookies Russell King - ARM Linux
2012-03-07 0:53 ` H Hartley Sweeten
2012-03-06 22:35 ` [PATCH 5/9] dmaengine: provide a common function for completing a dma descriptor Russell King - ARM Linux
2012-03-07 0:56 ` H Hartley Sweeten
2012-04-23 9:40 ` Boojin Kim
2012-04-23 9:50 ` Russell King - ARM Linux
2012-04-23 10:01 ` Vinod Koul
2012-04-23 11:06 ` Boojin Kim
2012-04-23 11:13 ` Russell King - ARM Linux
2012-03-06 22:35 ` [PATCH 6/9] dmaengine: consolidate tx_status functions Russell King - ARM Linux
2012-03-07 1:04 ` H Hartley Sweeten
2012-03-06 22:36 ` [PATCH 9/9] dmaengine: ensure all DMA engine drivers initialize their cookies Russell King - ARM Linux
2012-03-07 8:33 ` [PATCH v2 0/9] DMA engine cookie handling cleanups Linus Walleij
2012-03-07 9:06 ` Russell King - ARM Linux
2012-03-07 13:54 ` Vinod Koul
2012-03-12 16:11 ` Russell King - ARM Linux
2012-03-12 16:23 ` Vinod Koul
2012-03-13 8:40 ` Vinod Koul
2012-03-13 12:31 ` Russell King - ARM Linux
2012-03-13 14:38 ` Vinod Koul
2012-03-19 14:35 ` Vinod Koul
2012-03-07 18:09 ` Jassi Brar
2012-03-07 18:21 ` Russell King - ARM Linux
2012-03-07 18:44 ` Jassi Brar
2012-03-09 8:59 ` Shawn Guo
2012-03-13 11:45 ` Nicolas Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5F3374.8000506@atmel.com \
--to=nicolas.ferre@atmel$(echo .)com \
--cc=baohua.song@csr$(echo .)com \
--cc=dan.j.williams@intel$(echo .)com \
--cc=linus.walleij@stericsson$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=srinidhi.kasagar@stericsson$(echo .)com \
--cc=swarren@nvidia$(echo .)com \
--cc=vinod.koul@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox