Subject: Re: [PATCH v3 4/4] powerpc: Board support for GE IMP3A

From: Martyn Welch <[email-masked]>
Date: Tue, 13 Mar 2012 12:32:57 +0000

On 13/03/12 11:51, Linus Walleij wrote:
> On Mon, Mar 12, 2012 at 6:13 PM, Martyn Welch <[email-masked]> wrote:
> 
>> Initial board support for the GE IMP3A, a 3U compactPCI card with a p2020
>> processor.
> (...)
>> +++ b/arch/powerpc/configs/ge_imp3a_defconfig
>> @@ -0,0 +1,257 @@
>> +CONFIG_PPC_85xx=y
>> +CONFIG_SMP=y
>> +CONFIG_NR_CPUS=2
>> +CONFIG_EXPERIMENTAL=y
>> +CONFIG_SYSVIPC=y
>> +CONFIG_POSIX_MQUEUE=y
>> +CONFIG_BSD_PROCESS_ACCT=y
>> +CONFIG_BSD_PROCESS_ACCT_V3=y
>> +CONFIG_SPARSE_IRQ=y
> 
> This habit of changing a lot of defconfig stuff in a patch dealing with other
> stuff is alien in the ARM world. Especially when changing a horde of stuff
> that has nothing to do with the patch subject.
> 

This is adding the defconfig, it's support for a new board:

diff --git a/arch/powerpc/configs/ge_imp3a_defconfig
b/arch/powerpc/configs/ge_imp3a_defconfig
new file mode 100644
index 0000000..f8c51a4
--- /dev/null
+++ b/arch/powerpc/configs/ge_imp3a_defconfig

> But I don't really know how PPC does these things so who am I to
> speak ...
> 
> BTW: doesn't the "make saveconfig" reduce defconfigs on PPC?
> Paging Uwe on this.

This is the output of "make savedefconfig".

Martyn

-- 
Martyn Welch (Lead Software Engineer)  | Registered in England and Wales
GE Intelligent Platforms               | (3828642) at 100 Barbirolli Square
T +44(0)1327322748                     | Manchester, M2 3AB
E [email-masked]                  | VAT:GB 927559189