From: Scott Wood <scottwood@freescale•com>
To: Kumar Gala <galak@kernel•crashing.org>
Cc: linuxppc-dev@lists•ozlabs.org, r61911@freescale•com,
"<shuo.liu@freesacle•com>" <shuo.liu@freesacle•com>,
Zhao Chenhui <b35336@freescale•com>
Subject: Re: [PATCH] powerpc/85xx: Add machine check handler to fix PCIe erratum on mpc85xx
Date: Fri, 16 Mar 2012 15:42:37 -0500 [thread overview]
Message-ID: <4F63A5BD.1090207@freescale.com> (raw)
In-Reply-To: <2F2A8FBF-BD4D-4A53-A293-F5426F8C5BAA@kernel.crashing.org>
On 03/16/2012 03:35 PM, Kumar Gala wrote:
> On Feb 10, 2012, at 2:09 AM, <shuo.liu@freesacle•com> <shuo.liu@freesacle•com> wrote:
>> +static int is_in_pci_mem_space(phys_addr_t addr)
>> +{
>> + struct pci_controller *hose;
>> + struct resource *res;
>> + int i;
>> +
>> + list_for_each_entry(hose, &hose_list, list_node) {
>> + for (i = 0; i < 3; i++) {
>> + res = &hose->mem_resources[i];
>> + if ((res->flags & IORESOURCE_MEM) &&
>> + addr >= res->start && addr <= res->end)
>> + return 1;
>> + }
>> + }
>> + return 0;
>
> just move this into fsl_pci_mcheck_exception() no need for a separate function.
A separate function increases readability.
-Scott
next prev parent reply other threads:[~2012-03-16 20:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 8:09 [PATCH] powerpc/85xx: Add machine check handler to fix PCIe erratum on mpc85xx shuo.liu
2012-03-16 20:35 ` Kumar Gala
2012-03-16 20:42 ` Scott Wood [this message]
2012-03-16 21:03 ` Kumar Gala
2012-03-16 21:03 ` Kumar Gala
2012-03-26 6:14 ` Jia Hongtao-B38951
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F63A5BD.1090207@freescale.com \
--to=scottwood@freescale$(echo .)com \
--cc=b35336@freescale$(echo .)com \
--cc=galak@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=r61911@freescale$(echo .)com \
--cc=shuo.liu@freesacle$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox