From: Trilok Soni <tsoni@codeaurora•org>
To: Vinod Koul <vinod.koul@linux•intel.com>
Cc: Russell King <linux@arm•linux.org.uk>,
Ravi Kumar V <kumarrav@codeaurora•org>,
"Ira W. Snyder" <iws@ovro•caltech.edu>,
Srinidhi Kasagar <srinidhi.kasagar@stericsson•com>,
linux-arm-msm@vger•kernel.or, linux-kernel@vger•kernel.org,
Zhang Wei <zw@zh-kernel•org>,
Bryan Huntsman <bryanh@codeaurora•org>,
Al Viro <viro@zeniv•linux.org.uk>,
Barry Song <baohua.song@csr•com>,
Daniel Walker <dwalker@fifo99•com>,
Dan Williams <dan.j.williams@intel•com>,
linuxppc-dev@lists•ozlabs.org,
David Brown <davidb@codeaurora•org>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v5 1/2] dmaengine: Add context parameter to prep_dma_sg and prep_interleaved_dma
Date: Mon, 26 Mar 2012 12:25:56 +0530 [thread overview]
Message-ID: <4F7012FC.10203@codeaurora.org> (raw)
In-Reply-To: <1332743073.19804.26.camel@vkoul-udesk3>
On 3/26/2012 11:54 AM, Vinod Koul wrote:
> On Thu, 2012-03-22 at 19:52 +0530, Ravi Kumar V wrote:
>> Add new context parameter to DMA SG and Interleaveid mode for passing
> Typo ^^^^^^^^^^^^
Sorry, we will fix this.
>> diff --git a/drivers/misc/carma/carma-fpga-program.c b/drivers/misc/carma/carma-fpga-program.c
>> index a2d25e4..3739a12 100644
>> --- a/drivers/misc/carma/carma-fpga-program.c
>> +++ b/drivers/misc/carma/carma-fpga-program.c
>> @@ -530,7 +530,7 @@ static noinline int fpga_program_dma(struct fpga_dev *priv)
>> }
>>
>> /* setup and submit the DMA transaction */
>> - tx = chan->device->device_prep_dma_sg(chan,
>> + tx = chan->device->dmaengine_prep_dma_sg(chan,
>> table.sgl, num_pages,
>> vb->sglist, vb->sglen, 0);
> No the idea is that clients will not know anything about additionlay
> parameter hence avoiding abuse. You need to reread the patches sent by
> Alexandre.
>
> You need to
> 1) add wrappers over interleaved api which dont expose this additional
> parameter
> 2) move existing users to use these wrappers
Above two steps would be exactly same as
https://lkml.org/lkml/2012/3/8/401 - [PATCH 1/2 V2] dmaengine/dma_slave:
introduce inline wrappers, right?
> 3) add a new API which has your additional argument (not an opaque
> object) and this calls .device_xx callback with additional arg.
> 4. Above can be under conditional of your specific subsystem where these
> parameters are valid.
Now, this would be different from what Alexandre had submitted, since he
had added "void *context" parameter directly to existing callbacks
dma_slave_sg and and cyclic under struct dma_device.
And you prefer that we add new callbacks under "struct dma_device" for
our specific requirement with new name and with that extra non-opaque
object. After that add wrappers for these two new callbacks say
dmaengine_prep_dma_sg_ext and dmagengine_prep_interleaved_dma_ext (same
name goes for callback).
---Trilok Soni
--
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2012-03-26 7:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 14:22 [PATCH v5 1/2] dmaengine: Add context parameter to prep_dma_sg and prep_interleaved_dma Ravi Kumar V
2012-03-26 6:24 ` Vinod Koul
2012-03-26 6:55 ` Trilok Soni [this message]
2012-03-26 7:24 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7012FC.10203@codeaurora.org \
--to=tsoni@codeaurora$(echo .)org \
--cc=baohua.song@csr$(echo .)com \
--cc=bryanh@codeaurora$(echo .)org \
--cc=dan.j.williams@intel$(echo .)com \
--cc=davidb@codeaurora$(echo .)org \
--cc=dwalker@fifo99$(echo .)com \
--cc=iws@ovro$(echo .)caltech.edu \
--cc=kumarrav@codeaurora$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.or \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=srinidhi.kasagar@stericsson$(echo .)com \
--cc=vinod.koul@linux$(echo .)intel.com \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=zw@zh-kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox