From: Sergei Shtylyov <sshtylyov@mvista•com>
To: "Thang Q. Nguyen" <tqnguyen@apm•com>
Cc: devicetree-discuss@lists•ozlabs.org,
linux-kernel@vger•kernel.org,
Rob Herring <rob.herring@calxeda•com>,
linux-ide@vger•kernel.org, Paul Mackerras <paulus@samba•org>,
Jeff Garzik <jgarzik@pobox•com>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 1/1] Add support 2 SATA ports for Maui and change filename from sata_dwc_460ex.c to sata_dwc_4xx.c
Date: Mon, 09 Apr 2012 14:12:45 +0400 [thread overview]
Message-ID: <4F82B61D.8010502@mvista.com> (raw)
In-Reply-To: <1333447938-16461-1-git-send-email-tqnguyen@apm.com>
Hello.
On 03-04-2012 14:12, Thang Q. Nguyen wrote:
> Signed-off-by: Thang Q. Nguyen<tqnguyen@apm•com>
[...]
> diff --git a/arch/powerpc/boot/dts/bluestone.dts b/arch/powerpc/boot/dts/bluestone.dts
> index cfa23bf..803fda6 100644
> --- a/arch/powerpc/boot/dts/bluestone.dts
> +++ b/arch/powerpc/boot/dts/bluestone.dts
> @@ -155,6 +155,27 @@
> /*RXDE*/ 0x5 0x4>;
> };
>
> + /* SATA DWC devices */
> + SATA0: sata@bffd1000 {
> + compatible = "amcc,sata-apm821xx";
> + reg =<4 0xbffd1000 0x800 /* SATA0 */
> + 4 0xbffd0800 0x400>; /* AHBDMA */
> + dma-channel=<0>;
> + interrupt-parent =<&UIC0>;
> + interrupts =<26 4 /* SATA0 */
> + 25 4>; /* AHBDMA */
> + };
> +
> + SATA1: sata@bffd1800 {
> + compatible = "amcc,sata-apm821xx";
> + reg =<4 0xbffd1800 0x800 /* SATA1 */
> + 4 0xbffd0800 0x400>; /* AHBDMA */
> + dma-channel=<1>;
> + interrupt-parent =<&UIC0>;
> + interrupts =<27 4 /* SATA1 */
> + 25 4>; /* AHBDMA */
> + };
> +
So, this is dual SATA controller, not dual port SATA controller?
BTW, it's wrong to have the same AHBDMA resource in two device nodes I think.
MBR, Sergei
next prev parent reply other threads:[~2012-04-09 10:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 10:12 [PATCH 1/1] Add support 2 SATA ports for Maui and change filename from sata_dwc_460ex.c to sata_dwc_4xx.c Thang Q. Nguyen
2012-04-03 11:56 ` Sergei Shtylyov
2012-04-04 8:18 ` Thang Nguyen
2012-04-12 20:05 ` Jeff Garzik
2012-04-13 7:18 ` Thang Nguyen
2012-04-13 14:20 ` Jeff Garzik
2012-04-09 10:12 ` Sergei Shtylyov [this message]
2012-04-10 3:46 ` Thang Nguyen
2012-04-10 11:22 ` Sergei Shtylyov
2012-04-13 3:29 ` Thang Q. Nguyen
-- strict thread matches above, loose matches on Subject: below --
2012-03-27 10:26 Thang Q. Nguyen
2012-03-27 11:16 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F82B61D.8010502@mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=devicetree-discuss@lists$(echo .)ozlabs.org \
--cc=jgarzik@pobox$(echo .)com \
--cc=linux-ide@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=rob.herring@calxeda$(echo .)com \
--cc=tqnguyen@apm$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox